Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deterministic ordering when Add'ing to capability contract #15738

Closed
wants to merge 2 commits into from
Closed

Deterministic ordering when Add'ing to capability contract #15738

wants to merge 2 commits into from

Conversation

vyzaldysanchez
Copy link
Contributor

Requires

Supports

@vyzaldysanchez vyzaldysanchez changed the title Orders AddNodes and AddNodeOperators Deterministic ordering when `Add Dec 17, 2024
@vyzaldysanchez vyzaldysanchez changed the title Deterministic ordering when `Add Deterministic ordering when Add'ing to capability contract Dec 17, 2024
bolekk
bolekk requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@bolekk bolekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be doing that - the order is dictated by the input list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolekk bolekk bolekk requested changes

@krehermann krehermann Awaiting requested review from krehermann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyzaldysanchez @bolekk