Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCIP-4646 account for token transfer bytes overhead in execution cost #15737

Merged
merged 3 commits into from
Dec 17, 2024
Merged

CCIP-4646 account for token transfer bytes overhead in execution cost #15737

merged 3 commits into from
Dec 17, 2024
+53 −35

Conversation

0xsuryansh
Copy link
Member

No description provided.

@0xsuryansh 0xsuryansh changed the title CCIP-4646 include token transfer bytes overhead in execution cost CCIP-4646 account for token transfer bytes overhead in execution cost Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/early-cups-relax.md

This PR has been linked to Solidity Review Jira issue: CCIP-3966

@github-actions GitHub Actions
Copy link
Contributor

Static analysis results are available

Hey @0xsuryansh, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

@0xsuryansh 0xsuryansh marked this pull request as ready for review December 17, 2024 15:12
@0xsuryansh 0xsuryansh requested a review from a team as a code owner December 17, 2024 15:12
@0xsuryansh 0xsuryansh enabled auto-merge December 17, 2024 16:00
@0xsuryansh 0xsuryansh added this pull request to the merge queue Dec 17, 2024
Merged via the queue into develop with commit 631cd8f Dec 17, 2024
210 checks passed
@0xsuryansh 0xsuryansh deleted the CCIP-4646-include-tokenTransferBytesOverhead-in-executionCost branch December 17, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhweintraub jhweintraub jhweintraub approved these changes

@RensR RensR RensR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xsuryansh @RensR @jhweintraub