Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KS-602] Fix for remote executable client not respecting context #15721

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented Dec 16, 2024

When context is cancelled (e.g. on Engine instance shutdown), ClientRequest will shut down all pending sender goroutines with a log "context done, not sending request to peer" but it won't send anything back on the response channel. That will happen only much later, when a request expires (via expireRequests()).

Two solutions I considered:
(1) [IMPLEMENTED] Wait on the response channel together with the context.
(2) [ALTERNATIVE] Guarantee that ClientRequest always sends something back. Seems to be more error-prone and also a bit awkward to implement.

@bolekk bolekk requested review from a team as code owners December 16, 2024 22:11
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@bolekk bolekk force-pushed the KS-602-engine-slowness-fix branch from 62d9ada to 58db41a Compare December 16, 2024 22:19
Copy link
Contributor

github-actions bot commented Dec 16, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@bolekk bolekk force-pushed the KS-602-engine-slowness-fix branch from 58db41a to 0d95cd2 Compare December 16, 2024 23:18
ettec
ettec previously approved these changes Dec 17, 2024
@bolekk bolekk dismissed stale reviews from ettec and cedric-cordenier via dff3a9c December 17, 2024 15:13
@bolekk bolekk force-pushed the KS-602-engine-slowness-fix branch from 0d95cd2 to dff3a9c Compare December 17, 2024 15:13
@bolekk bolekk enabled auto-merge December 17, 2024 15:42
@bolekk bolekk added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2024
@bolekk bolekk added this pull request to the merge queue Dec 17, 2024
Merged via the queue into develop with commit 30e3a16 Dec 17, 2024
169 of 170 checks passed
@bolekk bolekk deleted the KS-602-engine-slowness-fix branch December 17, 2024 17:04
bolekk added a commit that referenced this pull request Dec 21, 2024
…se-hotfix

[KS-602] Fix for remote executable client not respecting context (#15721)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants