-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KS-602] Fix for remote executable client not respecting context #15721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see you updated files related to
|
bolekk
force-pushed
the
KS-602-engine-slowness-fix
branch
from
December 16, 2024 22:19
62d9ada
to
58db41a
Compare
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
krehermann
reviewed
Dec 16, 2024
bolekk
force-pushed
the
KS-602-engine-slowness-fix
branch
from
December 16, 2024 23:18
58db41a
to
0d95cd2
Compare
cedric-cordenier
previously approved these changes
Dec 17, 2024
ettec
previously approved these changes
Dec 17, 2024
bolekk
force-pushed
the
KS-602-engine-slowness-fix
branch
from
December 17, 2024 15:13
0d95cd2
to
dff3a9c
Compare
cedric-cordenier
approved these changes
Dec 17, 2024
krehermann
approved these changes
Dec 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 17, 2024
bolekk
added a commit
that referenced
this pull request
Dec 17, 2024
bolekk
added a commit
that referenced
this pull request
Dec 21, 2024
…se-hotfix [KS-602] Fix for remote executable client not respecting context (#15721)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When context is cancelled (e.g. on Engine instance shutdown), ClientRequest will shut down all pending sender goroutines with a log "context done, not sending request to peer" but it won't send anything back on the response channel. That will happen only much later, when a request expires (via expireRequests()).
Two solutions I considered:
(1) [IMPLEMENTED] Wait on the response channel together with the context.
(2) [ALTERNATIVE] Guarantee that ClientRequest always sends something back. Seems to be more error-prone and also a bit awkward to implement.