Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Version Heartbeat #15700

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Conversation

patrickhuie19
Copy link
Contributor

Requires

Supports

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

Copy link
Contributor

github-actions bot commented Dec 16, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Flakeguard Deployment Project , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakey Test Detection , SonarQube Scan

1. HTML output mismatch in health controller test: go_core_tests

Source of Error:
Run tests	2024-12-16T15:11:55.3196820Z health_controller_test.go:183: 
Run tests	2024-12-16T15:11:55.3197643Z 	Error Trace:	/home/runner/work/chainlink/chainlink/core/web/health_controller_test.go:183
Run tests	2024-12-16T15:11:55.3198214Z 	Error: 	Not equal: 
Run tests	2024-12-16T15:11:55.3255611Z 	 	expected: "<style>\n details {\n margin: 0.0em 0.0em 0.0em 0.4em;\n padding: 0.3em 0.0em 0.0em 0.4em;\n }\n pre {\n margin-left:1em;\n margin-top: 0;\n }\n summary {\n padding-bottom: 0.4em;\n }\n details {\n border: thin solid black;\n border-bottom-color: rgba(0,0,0,0);\n border-right-color: rgba(0,0,0,0);\n }\n .passing:after {\n color: blue;\n content: \" - (Passing)\";\n font-size:small;\n text-transform: uppercase;\n }\n .failing:after {\n color: red;\n content: \" - (Failing)\";\n font-weight: bold;\n font-size:small;\n text-transform: uppercase;\n }\n summary.noexpand::marker {\n color: rgba(100,101,10,0);\n }\n</style>\n<details open>\n <summary title=\"\"><span class=\"\">Cosmos</span></summary>\n <details open>\n <summary title=\"\"><span class=\"\">Foo</span></summary>\n <details open>\n <summary title=\"Cosmos.Foo.Chain\" class=\"noexpand\"><span class=\"passing\">Chain</span></summary>\n </details>\n <details open>\n <summary title=\"Cosmos.Foo.Relayer\" class=\"noexpand\"><span class=\"passing\">Relayer</span></summary>\n </details>\n <details open>\n <summary title=\"Cosmos.Foo.Txm\" class=\"noexpand\"><span class=\"passing\">Txm</span></summary>\n </details>\n </details>\n</details>\n<details open>\n <summary title=\"\"><span class=\"\">EVM</span></summary>\n <details open>\n <summary title=\"EVM.0\"><span class=\"passing\">0</span></summary>\n <details open>\n <summary title=\"EVM.0.BalanceMonitor\" class=\"noexpand\"><span class=\"passing\">BalanceMonitor</span></summary>\n </details>\n <details open>\n <summary title=\"EVM.0.HeadBroadcaster\" class=\"noexpand\"><span class=\"passing\">HeadBroadcaster</span></summary>\n </details>\n <details open>\n <summary title=\"EVM.0.HeadTracker\"><span class=\"passing\">HeadTracker</span></summary>\n <details open>\n <summary title=\"EVM.0.HeadTracker.HeadListener\"><span class=\"failing\">HeadListener</span></summary>\n <pre>Listener is not connected</pre>\n </details>\n </details>\n <details open>\n <summary title=\"EVM.0.LogBroadcaster\" class=\"noexpand\"><span class=\"passing\">LogBroadcaster</span></summary>\n </details>\n <details open>\n <summary title=\"EVM.0.Relayer\" class=\"noexpand\"><span class=\"passing\">Relayer</span></summary>\n </details>\n <details open>\n <summary title=\"EVM.0.Txm\"><span class=\"passing\">Txm</span></summary>\n <details open>\n <summary title=\"EVM.0.Txm.BlockHistoryEstimator\" class=\"noexpand\"><span class=\"passing\">BlockHistoryEstimator</span></summary>\n </details>\n <details open>\n <summary title=\"EVM.0.Txm.Broadcaster\" class=\"noexpand\"><span class=\"passing\">Broadcaster</span></summary>\n </details>\n <details open>\n <summary title=\"EVM.0.Txm.Confirmer\" class=\"noexpand\"><span class=\"passing\">Confirmer</span></summary>\n </details>\n <details open>\n <summary title=\"EVM.0.Txm.Finalizer\" class=\"noexpand\"><span class=\"passing\">Finalizer</span></summary>\n </details>\n <details open>\n <summary title=\"EVM.0.Txm.WrappedEvmEstimator\" class=\"noexpand\"><span class=\"passing\">WrappedEvmEstimator</span></summary>\n </details>\n </details>\n </details>\n</details>\n<details open>\n <summary title=\"HeadReporter\" class=\"noexpand\"><span class=\"passing\">HeadReporter</span></summary>\n</details>\n<details open>\n <summary title=\"JobSpawner\" class=\"noexpand\"><span class=\"passing\">JobSpawner</span></summary>\n</details>\n<details open>\n <summary title=\"\"><span class=\"\">Mailbox</span></summary>\n <details open>\n <summary title=\"Mailbox.Monitor\" class=\"noexpand\"><span class=\"passing\">Monitor</span></summary>\n </details>\n</details>\n<details open>\n <summary title=\"\"><span class=\"\">Mercury</span></summary>\n <details open>\n <summary title=\"Mercury.WSRPCPool\"><span class=\"passing\">WSRPCPool</span></summary>\n <details open>\n <summary title=\"Mercury.WSRPCPool.CacheSet\" class=\"noexpand\"><span class=\"passing\">CacheSet</span></summary>\n </details>\n </details>\n</details>\n<details open>\n <summary title=\"PipelineORM\" class=\"noexpand\"><span class=\"passing\">PipelineORM</span></summary>\n</details>\n<details open>\n <summary title=\"PipelineRunner\"><span class=\"passing\">PipelineRunner</span></summary>\n <details open>\n <summary title=\"PipelineRunner.BridgeCache\" class=\"noexpand\"><span class=\"passing\">BridgeCache</span></summary>\n </details>\n</details>\n<details open>\n <summary title=\"RetirementReportCache\" class=\"noexpand\"><span class=\"passing\">RetirementReportCache</span></summary>\n</details>\n<details open>\n <summary title=\"\"><span class=\"\">Solana</span></summary>\n <details open>\n <summary title=\"\"><span class=\"\">Bar</span></summary>\n <details open>\n <summary title=\"Solana.Bar.Chain\" class=\"noexpand\"><span class=\"passing\">Chain</span></summary>\n </details>\n <details open>\n <summary title=\"Solana.Bar.Relayer\" class=\"noexpand\"><span class=\"passing\">Relayer</span></summary>\n </details>\n <details open>\n <summary title=\"Solana.Bar.Txm\" class=\"noexpand\"><span class=\"passing\">Txm</span></summary>\n </details>\n </details>\n</details>\n<details open>\n <summary title=\"\"><span class=\"\">StarkNet</span></summary>\n <details open>\n <summary title=\"\"><span class=\"\">Baz</span></summary>\n <details open>\n <summary title=\"StarkNet.Baz.Chain\" class=\"noexpand\"><span class=\"passing\">Chain</span></summary>\n </details>\n <details open>\n <summary title=\"StarkNet.Baz.Relayer\" class=\"noexpand\"><span class=\"passing\">Relayer</span></summary>\n </details>\n <details open>\n <summary title=\"StarkNet.Baz.Txm\" class=\"noexpand\"><span class=\"passing\">Txm</span></summary>\n </details>\n </details>\n</details>\n<details open>\n <summary title=\"TelemetryManager\" class=\"noexpand\"><span class=\"passing\">TelemetryManager</span></summary>\n</details>\n<details open>\n <summary title=\"WorkflowDBStore\" class=\"noexpand\"><span class=\"passing\">WorkflowDBStore</span></summary>\n</details>"
Run tests	2024-12-16T15:11:55.3331512Z 	 	actual : "<style>\n details {\n margin: 0.0em 0.0em 0.0em 0.4em;\n padding: 0.3em 0.0em 0.0em 0.4em;\n }\n pre {\n margin-left:1em;\n margin-top: 0;\n }\n summary {\n padding-bottom: 0.4em;\n }\n details {\n border: thin solid black;\n border-bottom-color: rgba(0,0,0,0);\n border-right-color: rgba(0,0,0,0);\n }\n .passing:after {\n color: blue;\n content: \" - (Passing)\";\n font-size:small;\n text-transform: uppercase;\n }\n .failing:after {\n color: red;\n content: \" - (Failing)\";\n font-weight: bold;\n font-size:small;\n text-transform: uppercase;\n }\n summary.noexpand::marker {\n color: rgba(100,101,10,0);\n }\n</style>\n<details open>\n <summary title=\"\"><span class=\"\">Cosmos</span></summary>\n <details open>\n <summary title=\"\"><span class=\"\">Foo</span></summary>\n <details open>\n <summary title=\"Cosmos.Foo.Chain\" class=\"noexpand\"><span class=\"passing\">Chain</span></summary>\n </details>\n <details open>\n <summary title=\"Cosmos.Foo.Relayer\" class=\"noexpand\"><span class=\"passing\">Relayer</span></summary>\n </details>\n <details open>\n <summary title=\"Cosmos.Foo.Txm\" class=\"noexpand\"><span class=\"passing\">Txm</span></summary>\n </details>\n </details>\n</details>\n<details open>\n <summary title=\"\"><span class=\"\">EVM</span></summary>\n <details open>\n <summary title=\"EVM.0\"><span class=\"passing\">0</span></summary>\n <details open>\n <summary title=\"EVM.0.BalanceMonitor\" class=\"noexpand\"><span class=\"passing\">BalanceMonitor</span></summary>\n </details>\n <details open>\n <summary title=\"EVM.0.HeadBroadcaster\" class=\"noexpand\"><span class=\"passing\">HeadBroadcaster</span></summary>\n </details>\n <details open>\n <summary title=\"EVM.0.HeadTracker\"><span class=\"passing\">HeadTracker</span></summary>\n <details open>\n <summary title=\"EVM.0.HeadTracker.HeadListener\"><span class=\"failing\">HeadListener</span></summary>\n <pre>Listener is not connected</pre>\n </details>\n </details>\n <details open>\n <summary title=\"EVM.0.LogBroadcaster\" class=\"noexpand\"><span class=\"passing\">LogBroadcaster</span></summary>\n </details>\n <details open>\n <summary title=\"EVM.0.Relayer\" class=\"noexpand\"><span class=\"passing\">Relayer</span></summary>\n </details>\n <details open>\n <summary title=\"EVM.0.Txm\"><span class=\"passing\">Txm</span></summary>\n <details open>\n <summary title=\"EVM.0.Txm.BlockHistoryEstimator\" class=\"noexpand\"><span class=\"passing\">BlockHistoryEstimator</span></summary>\n </details>\n <details open>\n <summary title=\"EVM.0.Txm.Broadcaster\" class=\"noexpand\"><span class=\"passing\">Broadcaster</span></summary>\n </details>\n <details open>\n <summary title=\"EVM.0.Txm.Confirmer\" class=\"noexpand\"><span class=\"passing\">Confirmer</span></summary>\n </details>\n <details open>\n <summary title=\"EVM.0.Txm.Finalizer\" class=\"noexpand\"><span class=\"passing\">Finalizer</span></summary>\n </details>\n <details open>\n <summary title=\"EVM.0.Txm.WrappedEvmEstimator\" class=\"noexpand\"><span class=\"passing\">WrappedEvmEstimator</span></summary>\n </details>\n </details>\n </details>\n</details>\n<details open>\n <summary title=\"HeadReporter\" class=\"noexpand\"><span class=\"passing\">HeadReporter</span></summary>\n</details>\n<details open>\n <summary title=\"JobSpawner\" class=\"noexpand\"><span class=\"passing\">JobSpawner</span></summary>\n</details>\n<details open>\n <summary title=\"\"><span class=\"\">Mailbox</span></summary>\n <details open>\n <summary title=\"Mailbox.Monitor\" class=\"noexpand\"><span class=\"passing\">Monitor</span></summary>\n </details>\n</details>\n<details open>\n <summary title=\"\"><span class=\"\">Mercury</span></summary>\n <details open>\n <summary title=\"Mercury.WSRPCPool\"><span class=\"passing\">WSRPCPool</span></summary>\n <details open>\n <summary title=\"Mercury.WSRPCPool.CacheSet\" class=\"noexpand\"><span class=\"passing\">CacheSet</span></summary>\n </details>\n </details>\n</details>\n<details open>\n <summary title=\"NodeHeartbeat\" class=\"noexpand\"><span class=\"passing\">NodeHeartbeat</span></summary>\n</details>\n<details open>\n <summary title=\"PipelineORM\" class=\"noexpand\"><span class=\"passing\">PipelineORM</span></summary>\n</details>\n<details open>\n <summary title=\"PipelineRunner\"><span class=\"passing\">PipelineRunner</span></summary>\n <details open>\n <summary title=\"PipelineRunner.BridgeCache\" class=\"noexpand\"><span class=\"passing\">BridgeCache</span></summary>\n </details>\n</details>\n<details open>\n <summary title=\"RetirementReportCache\" class=\"noexpand\"><span class=\"passing\">RetirementReportCache</span></summary>\n</details>\n<details open>\n <summary title=\"\"><span class=\"\">Solana</span></summary>\n <details open>\n <summary title=\"\"><span class=\"\">Bar</span></summary>\n <details open>\n <summary title=\"Solana.Bar.Chain\" class=\"noexpand\"><span class=\"passing\">Chain</span></summary>\n </details>\n <details open>\n <summary title=\"Solana.Bar.Relayer\" class=\"noexpand\"><span class=\"passing\">Relayer</span></summary>\n </details>\n <details open>\n <summary title=\"Solana.Bar.Txm\" class=\"noexpand\"><span class=\"passing\">Txm</span></summary>\n </details>\n </details>\n</details>\n<details open>\n <summary title=\"\"><span class=\"\">StarkNet</span></summary>\n <details open>\n <summary title=\"\"><span class=\"\">Baz</span></summary>\n <details open>\n <summary title=\"StarkNet.Baz.Chain\" class=\"noexpand\"><span class=\"passing\">Chain</span></summary>\n </details>\n <details open>\n <summary title=\"StarkNet.Baz.Relayer\" class=\"noexpand\"><span class=\"passing\">Relayer</span></summary>\n </details>\n <details open>\n <summary title=\"StarkNet.Baz.Txm\" class=\"noexpand\"><span class=\"passing\">Txm</span></summary>\n </details>\n </details>\n</details>\n<details open>\n <summary title=\"TelemetryManager\" class=\"noexpand\"><span class=\"passing\">TelemetryManager</span></summary>\n</details>\n<details open>\n <summary title=\"WorkflowDBStore\" class=\"noexpand\"><span class=\"passing\">WorkflowDBStore</span></summary>\n</details>"
Run tests	2024-12-16T15:11:55.3350339Z 	 	
Run tests	2024-12-16T15:11:55.3350842Z 	 	Diff:
Run tests	2024-12-16T15:11:55.3351279Z 	 	--- Expected
Run tests	2024-12-16T15:11:55.3351837Z 	 	+++ Actual
Run tests	2024-12-16T15:11:55.3352325Z 	 	@@ -114,2 +114,5 @@
Run tests	2024-12-16T15:11:55.3352872Z 	 	 <details open>
Run tests	2024-12-16T15:11:55.3354261Z 	 	+ <summary title="NodeHeartbeat" class="noexpand"><span class="passing">NodeHeartbeat</span></summary>
Run tests	2024-12-16T15:11:55.3354992Z 	 	+</details>
Run tests	2024-12-16T15:11:55.3355439Z 	 	+<details open>
Run tests	2024-12-16T15:11:55.3356867Z 	 	 <summary title="PipelineORM" class="noexpand"><span class="passing">PipelineORM</span></summary>

Why: The test expected a specific HTML structure, but the actual output included additional elements (NodeHeartbeat and PipelineORM) that were not in the expected output.

Suggested fix: Update the expected HTML output in the test to include the NodeHeartbeat and PipelineORM elements, ensuring it matches the actual output.

2. CSA key does not exist: go_core_tests

Source of Error:
Run tests	2024-12-16T15:11:55.3465584Z logger.go:146: 2024-12-16T15:08:48.549Z	ERROR	chainlink/application.go:822	[Feeds Service] Failed to start CSA key does not exist	{"version": "unset@unset"}
Run
</cicore>
  
    

<operatoruici>

## AER Report: [Operator UI CI](https://github.com/smartcontractkit/chainlink/actions/runs/12355335415) ran successfully :white_check_mark:

[aer_workflow](https://github.com/smartcontractkit/chainlink/actions/runs/12355367441/job/34478830616) , [commit](https://github.com/smartcontractkit/chainlink/commit/0e5c40db23d5033039229d3856a2820c1294b242)

</operatoruici>

@patrickhuie19 patrickhuie19 force-pushed the feature/KS-460/heartbeat branch from 2ec5a40 to 0e5c40d Compare December 16, 2024 15:00
@patrickhuie19 patrickhuie19 changed the title Feature/ks 460/heartbeat Node Version Heartbeat Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant