Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow registry contract tweaks #15649

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Workflow registry contract tweaks #15649

wants to merge 3 commits into from

Conversation

eutopian
Copy link
Contributor

@eutopian eutopian commented Dec 11, 2024 •
edited
Loading

  1. Remove unnecessary curr == new workflowID check
    We no longer need this because we now check for uniqueness of the workflowID, which already ensures that the new one is not the same as the old one
  2. Use memory instead of storage when getting workflow for efficiency
    Update the fields directly for the fields that need updating

@eutopian
small tweaks to the workflow registry contract: 1) remove redundant s…
d033434 
…ame workflow check 2) use memory instead of storage for efficiency
@eutopian eutopian requested a review from a team as a code owner December 11, 2024 20:53
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to contracts. Please run pnpm changeset in the contracts directory to add a changeset.

@github-actions GitHub Actions
Copy link
Contributor

Static analysis results are available

Hey @eutopian, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eutopian