Custom Fallback TOML Config #15617
Open
Custom Fallback TOML Config #15617
+900
−235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // fallback.toml(defaults dir) <- fallback.toml(env CL_CHAIN_FALLBACK) <- ChainSpecific.toml(env CL_CHAIN_DEFAULTS) | ||
| // | ||
| // the custom fallback gets processed and overrides the default fallback | ||
| if path := env.CustomFallback.Get(); path != "" { |
There was a problem hiding this comment.
can we lock this in with a testscripts test like in https://github.com/smartcontractkit/chainlink/pull/14090/files#diff-ea10429fdb1fbc100e3d8082e39e6d40a12f82b48c1f37ab9158b6c3c0e44d81 ?
There was a problem hiding this comment.
Good idea. I'll add that
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
EasterTheBunny
force-pushed
the
etb/toml-custom-fallback
branch
from
1d753ac to
436023c
Compare
jmank88
reviewed
Dec 13, 2024
EasterTheBunny
force-pushed
the
etb/toml-custom-fallback
branch
2 times, most recently
from
a449414 to
f57243d
Compare
This commit provides using an existing env var `CL_CHAIN_DEFAULTS` as a path to a custom `fallback.toml`. This allows plugins to define their own set of fallback options apart from the core node which override the default fallback options.
EasterTheBunny
force-pushed
the
etb/toml-custom-fallback
branch
from
f57243d to
4515f8a
Compare
EasterTheBunny
force-pushed
the
etb/toml-custom-fallback
branch
from
ba58f5c to
2a8f287
Compare
mateusz-sekara
previously approved these changes
Dec 13, 2024
jmank88
reviewed
Dec 13, 2024
jmank88
reviewed
Dec 13, 2024
jmank88
reviewed
Dec 13, 2024
jmank88
reviewed
Dec 13, 2024
jmank88
reviewed
Dec 13, 2024
jmank88
requested changes
Dec 13, 2024
jmank88
reviewed
Dec 13, 2024
jmank88
reviewed
Dec 18, 2024
There was a problem hiding this comment.
Yup. I don't know why that is there. I can remove it
There was a problem hiding this comment.
Now I'm not sure what this is. It must be incidental because I added a new .txtar file to handle the new test case. I don't think I can remove it.
There was a problem hiding this comment.
What happens if you revert this file? I thought it would only update from a manual command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides using an existing env var
CL_CHAIN_DEFAULTSas a path to a customfallback.toml. This allows plugins to define their own set of fallback options apart from the core node which override the default fallback options.CCIP-4395