BCFR-1081: Fix flaky LogPoller testhelper deployment #15579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
…once has been incremented
reductionista
force-pushed
the
BCFR-1081-logpoller-testhelper-flaky-deployment
branch
from
ce49b7a to
f630426
Compare
dhaidashenko
approved these changes
Dec 10, 2024
patrickhuie19
approved these changes
Dec 10, 2024
reductionista
deleted the
BCFR-1081-logpoller-testhelper-flaky-deployment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCFR-1081
Avoid a race condition where DeployContract() returns before PendingNonce increments. This race possibility was introduced by the new simulated version of geth we bumped to recently.
Might be considered a bug in geth, but easier to just work around it for now instead of opening an issue there and waiting for a response.