Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCIP-4223 bubble up revert for estimation #15504

Merged
merged 24 commits into from
Jan 10, 2025

Conversation

0xsuryansh
Copy link
Member

@0xsuryansh 0xsuryansh commented Dec 4, 2024

PR adds logic to bubble up the revert when gas estimation address Is address(1)

@0xsuryansh 0xsuryansh changed the title feat: fix estimation by adding a reverting clause CCIP-4223 fix estimation by adding a reverting clause Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Static analysis results are available

Hey @0xsuryansh, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/twelve-pianos-chew.md

This PR has been linked to Solidity Review Jira issue: CCIP-3966

Copy link
Contributor

github-actions bot commented Dec 4, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

# Conflicts:
#	contracts/gas-snapshots/ccip.gas-snapshot
#	core/gethwrappers/ccip/generated/multi_ocr3_helper/multi_ocr3_helper.go
#	core/gethwrappers/ccip/generated/offramp/offramp.go
#	core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt
@0xsuryansh 0xsuryansh marked this pull request as ready for review December 9, 2024 12:34
@0xsuryansh 0xsuryansh requested a review from a team as a code owner December 9, 2024 12:34
@0xsuryansh 0xsuryansh requested a review from RensR December 9, 2024 12:35
@0xsuryansh 0xsuryansh requested review from a team as code owners December 9, 2024 13:05
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Flakeguard Summary

Setting Value
Project github.com/smartcontractkit/chainlink/v2
Max Pass Ratio 100.00%
Test Run Count 3
Race Detection false
Excluded Tests TestChainComponents

Found Flaky Tests ❌

Category Total
Tests 1
Panicked Tests 0
Raced Tests 0
Flaky Tests 1
Flaky Test Ratio 100.00%
Runs 3
Passes 0
Failures 3
Skips 0
Pass Ratio 0.00%
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestDeployAllV1_6 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/deployment_test false 133.333333ms @smartcontractkit/ccip-onchain

@0xsuryansh 0xsuryansh force-pushed the CCIP-4223_fix-gas-estimation branch from 9b8c6c9 to 5686b69 Compare December 9, 2024 13:48
@0xsuryansh 0xsuryansh changed the title CCIP-4223 fix estimation by adding a reverting clause CCIP-4223 bubble up revert for estimation Dec 9, 2024
# Conflicts:
#	contracts/gas-snapshots/ccip.gas-snapshot
#	core/gethwrappers/ccip/generated/multi_ocr3_helper/multi_ocr3_helper.go
#	core/gethwrappers/ccip/generated/offramp/offramp.go
#	core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt
@0xsuryansh 0xsuryansh requested a review from jhweintraub January 6, 2025 11:19
# Conflicts:
#	core/gethwrappers/ccip/generated/multi_ocr3_helper/multi_ocr3_helper.go
#	core/gethwrappers/ccip/generated/offramp/offramp.go
#	core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt
@0xsuryansh 0xsuryansh enabled auto-merge January 9, 2025 11:18
import {IERC20} from "../../../../vendor/openzeppelin-solidity/v4.8.3/contracts/token/ERC20/IERC20.sol";

contract OffRamp_trialExecute is OffRampSetup {
address private constant GAS_ESTIMATION_SENDER = address(0xC11C11C11C11C11C11C11C11C11C11C11C11C1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we can import this value and not have to redefine it. Probably means moving it to the internal lib? Would be nice if the offchain code can also use a reference and not a duplicated value

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to Internal

@smartcontractkit smartcontractkit deleted a comment from github-actions bot Jan 9, 2025
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@0xsuryansh 0xsuryansh added this pull request to the merge queue Jan 10, 2025
Merged via the queue into develop with commit 437ef64 Jan 10, 2025
207 checks passed
@0xsuryansh 0xsuryansh deleted the CCIP-4223_fix-gas-estimation branch January 10, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants