integration-tests/smoke/ccip: add max batch size test #15403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makramkd
requested review from
winder,
rstout,
asoliman92,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
dimkouv
approved these changes
Nov 26, 2024
| case <-ctx.Done(): | ||
| require.FailNow(t, "didn't get all errors before test context was done") | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: maybe cleaner with sync.WaitGroup
There was a problem hiding this comment.
Unfortunately, need the errors from the channel to check them
| e.Env.Chains[sourceChain].DeployerKey, | ||
| otherSender, | ||
| } | ||
| errs = make(chan error, len(transactors)) |
There was a problem hiding this comment.
I guess channel's size should be 0 or 1 https://github.com/uber-go/guide/blob/master/style.md#channel-size-is-one-or-none
There was a problem hiding this comment.
Actually did not work with an unbuffered channel, I tried that initially
mateusz-sekara
approved these changes
Nov 26, 2024
0xnogo
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://smartcontract-it.atlassian.net/browse/CCIP-4168