Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solana commit codec, need to add test #15320

Conversation

huangzhen1997
Copy link
Contributor

Requires

Supports

Copy link
Contributor

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Find New Flaky Tests In Chainlink Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Find New Flaky Tests In Deployment Project , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Find New Flaky Tests In Chainlink Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/ccipsolana/ccip_router... , Find New Flaky Tests In Chainlink Project / Report , Flakey Test Detection , SonarQube Scan

1. No go files to analyze

[A 1 <= 10 words sentence that describes the error]:[job id where the error happened]

Golang Lint 2024-11-19T23:18:11.2111064Z level=error msg="Running error: context loading failed: no go files to analyze: running `go mod tidy` may solve the problem"

Why: The error indicates that the golangci-lint tool could not find any Go files to analyze in the specified directory. This often happens if the Go module dependencies are not properly set up or if there are no Go files in the directory.

Suggested fix: Run go mod tidy to ensure all dependencies are correctly listed and fetched. Verify that there are Go files in the directory being analyzed.

2. No such file or directory

[A 1 <= 10 words sentence that describes the error]:[job id where the error happened]

Golang Lint 2024-11-19T23:18:11.2520149Z cat: ./golangci-lint-report.xml: No such file or directory

Why: The golangci-lint step failed to generate the golangci-lint-report.xml file because the linter did not find any Go files to analyze, leading to no output file being created.

Suggested fix: Ensure that the linter runs successfully by addressing the root cause of the missing Go files. Running go mod tidy and verifying the presence of Go files should resolve this.

3. Process completed with exit code 1

[A 1 <= 10 words sentence that describes the error]:[job id where the error happened]

Ensure clean after tidy 2024-11-19T23:22:42.6538626Z ##[error]Process completed with exit code 1.

Why: The git diff --minimal --cached --exit-code command found differences in the go.mod file, indicating that the repository is not clean after running go mod tidy.

Suggested fix: Commit the changes to the go.mod file after running go mod tidy to ensure the repository is clean.

4. Updates to go.mod needed

[A 1 <= 10 words sentence that describes the error]:[job id where the error happened]

Run tests 2024-11-19T23:19:04.5780410Z go: updates to go.mod needed; to update it:
Run tests 2024-11-19T23:19:04.5781927Z 	go mod tidy

Why: The Go tests failed because the go.mod file is not up-to-date. This can cause dependency issues and prevent the tests from running correctly.

Suggested fix: Run go mod tidy to update the go.mod file and ensure all dependencies are correctly listed.

Copy link
Contributor

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the go bindings are directly available, let's leverage them through an import: https://github.com/smartcontractkit/chainlink-ccip/tree/main/chains/solana/gobindings

@archseer archseer force-pushed the NONEVM-935/implement-ccip-solana-plugin-commitReport-codec branch from a62a321 to c79a406 Compare December 24, 2024 06:43
This reverts commit d44ab93, reversing
changes made to a62a321.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants