Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccip - rmn cursing support #15263

Merged
merged 10 commits into from
Nov 26, 2024
Merged

ccip - rmn cursing support #15263

merged 10 commits into from
Nov 26, 2024

Conversation

dimkouv
Copy link
Contributor

@dimkouv dimkouv commented Nov 15, 2024

  • Upgrade cl-ccip
  • Add RMNRemote.getCursedSubjects method to contract reader setup

requires: smartcontractkit/chainlink-ccip#317

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Nov 15, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Flakeguard Deployment Project / Get Tests To Run , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakeguard Deployment Project / Run Tests (github.com/smartcontractkit/chainlink/deployment/ccip/changeset, ubuntu-latest) , Flakey Test Detection , SonarQube Scan , Flakeguard Deployment Project / Report

1. Error stopping job service:[Run tests with flakeguard]

Source of Error:
Run tests with flakeguard	2024-11-26T10:22:13.5668363Z logger.go:146: 2024-11-26T10:20:02.726Z	DPANIC	JobSpawner	job/spawner.go:175	Error stopping job service	{"version": "unset@unset", "jobID": 1, "subservice": 3, "serviceType": "*launcher.launcher", "err": "failed to close RMN home reader: has already been stopped: already stopped; failed to close RMN home reader: has already been stopped: already stopped; failed to close RMN home reader: has already been stopped: already stopped; failed to close RMN home reader: has already been stopped: already stopped", "errCauses": [{"error": "failed to close RMN home reader: has already been stopped: already stopped"}, {"error": "failed to close RMN home reader: has already been stopped: already stopped"}, {"error": "failed to close RMN home reader: has already been stopped: already stopped"}, {"error": "failed to close RMN home reader: has already been stopped: already stopped"}]}
Run tests with flakeguard	2024-11-26T10:22:13.5668831Z github.com/smartcontractkit/chainlink/v2/core/services/job.(*spawner).stopService
Run tests with flakeguard	2024-11-26T10:22:13.5669258Z 	/home/runner/work/chainlink/chainlink/core/services/job/spawner.go:175
Run tests with flakeguard	2024-11-26T10:22:13.5669734Z github.com/smartcontractkit/chainlink/v2/core/services/job.(*spawner).stopAllServices
Run tests with flakeguard	2024-11-26T10:22:13.5670145Z 	/home/runner/work/chainlink/chainlink/core/services/job/spawner.go:152
Run tests with flakeguard	2024-11-26T10:22:13.5670589Z github.com/smartcontractkit/chainlink/v2/core/services/job.(*spawner).Close.func1
Run tests with flakeguard	2024-11-26T10:22:13.5671003Z 	/home/runner/work/chainlink/chainlink/core/services/job/spawner.go:114
Run tests with flakeguard	2024-11-26T10:22:13.5671451Z github.com/smartcontractkit/chainlink-common/pkg/services.(*StateMachine).StopOnce
Run tests with flakeguard	2024-11-26T10:22:13.5672287Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/services/state.go:132
Run tests with flakeguard	2024-11-26T10:22:13.5672700Z github.com/smartcontractkit/chainlink/v2/core/services/job.(*spawner).Close
Run tests with flakeguard	2024-11-26T10:22:13.5673119Z 	/home/runner/work/chainlink/chainlink/core/services/job/spawner.go:112
Run tests with flakeguard	2024-11-26T10:22:13.5673684Z github.com/smartcontractkit/chainlink/v2/core/services/chainlink.(*ChainlinkApplication).stop.func1
Run tests with flakeguard	2024-11-26T10:22:13.5674162Z 	/home/runner/work/chainlink/chainlink/core/services/chainlink/application.go:779
Run tests with flakeguard	2024-11-26T10:22:13.5674302Z sync.(*Once).doSlow
Run tests with flakeguard	2024-11-26T10:22:13.5674625Z 	/opt/hostedtoolcache/go/1.23.3/x64/src/sync/once.go:76
Run tests with flakeguard	2024-11-26T10:22:13.5674812Z sync.(*Once).Do
Run tests with flakeguard	2024-11-26T10:22:13.5675131Z 	/opt/hostedtoolcache/go/1.23.3/x64/src/sync/once.go:67
Run tests with flakeguard	2024-11-26T10:22:13.5675653Z github.com/smartcontractkit/chainlink/v2/core/services/chainlink.(*ChainlinkApplication).stop
Run tests with flakeguard	2024-11-26T10:22:13.5676135Z 	/home/runner/work/chainlink/chainlink/core/services/chainlink/application.go:764
Run tests with flakeguard	2024-11-26T10:22:13.5676711Z github.com/smartcontractkit/chainlink/v2/core/services/chainlink.(*ChainlinkApplication).Stop
Run tests with flakeguard	2024-11-26T10:22:13.5677191Z 	/home/runner/work/chainlink/chainlink/core/services/chainlink/application.go:757
Run tests with flakeguard	2024-11-26T10:22:13.5677699Z github.com/smartcontractkit/chainlink/deployment/ccip/changeset.NewMemoryEnvironment.func1
Run tests with flakeguard	2024-11-26T10:22:13.5678197Z 	/home/runner/work/chainlink/chainlink/deployment/ccip/changeset/test_helpers.go:200
Run tests with flakeguard	2024-11-26T10:22:13.5678389Z testing.(*common).Cleanup.func1
Run tests with flakeguard	2024-11-26T10:22:13.5678755Z 	/opt/hostedtoolcache/go/1.23.3/x64/src/testing/testing.go:1176
Run tests with flakeguard	2024-11-26T10:22:13.5678938Z testing.(*common).runCleanup
Run tests with flakeguard	2024-11-26T10:22:13.5679302Z 	/opt/hostedtoolcache/go/1.23.3/x64/src/testing/testing.go:1354
Run tests with flakeguard	2024-11-26T10:22:13.5679506Z testing.tRunner.func2
Run tests with flakeguard	2024-11-26T10:22:13.5679867Z 	/opt/hostedtoolcache/go/1.23.3/x64/src/testing/testing.go:1684
Run tests with flakeguard	2024-11-26T10:22:13.5679995Z runtime.Goexit
Run tests with flakeguard	2024-11-26T10:22:13.5680340Z 	/opt/hostedtoolcache/go/1.23.3/x64/src/runtime/panic.go:629
Run tests with flakeguard	2024-11-26T10:22:13.5680511Z testing.(*common).FailNow
Run tests with flakeguard	2024-11-26T10:22:13.5680872Z 	/opt/hostedtoolcache/go/1.23.3/x64/src/testing/testing.go:1006
Run tests with flakeguard	2024-11-26T10:22:13.5681103Z github.com/stretchr/testify/require.NoError
Run tests with flakeguard	2024-11-26T10:22:13.5681587Z 	/home/runner/go/pkg/mod/github.com/stretchr/[email protected]/require/require.go:1357
Run tests with flakeguard	2024-11-26T10:22:13.5682025Z github.com/smartcontractkit/chainlink/deployment/ccip/changeset.TestSendRequest
Run tests with flakeguard	2024-11-26T10:22:13.5682524Z 	/home/runner/work/chainlink/chainlink/deployment/ccip/changeset/test_helpers.go:457
Run tests with flakeguard	2024-11-26T10:22:13.5682980Z github.com/smartcontractkit/chainlink/deployment/ccip/changeset.TestAddChainInbound
Run tests with flakeguard	2024-11-26T10:22:13.5683488Z 	/home/runner/work/chainlink/chainlink/deployment/ccip/changeset/add_chain_test.go:246
Run tests with flakeguard	2024-11-26T10:22:13.5683617Z testing.tRunner
Run tests with flakeguard	2024-11-26T10:22:13.5683978Z 	/opt/hostedtoolcache/go/1.23.3/x64/src/testing/testing.go:1690

Why: The error occurs because the job service is being stopped multiple times, leading to repeated attempts to close the RMN home reader, which has already been stopped.

Suggested fix: Ensure that the job service stop logic checks if the service is already stopped before attempting to stop it again. This can prevent redundant stop attempts and avoid the error.

2. Connection refused:[Run tests with flakeguard]

Source of Error:
Run tests with flakeguard	2024-11-26T10:22:13.5638512Z logger.go:146: 2024-11-26T10:20:02.722Z	WARN	SingletonPeerWrapper	ragep2p/ragep2p.go:639	Dial error	{"version": "unset@unset", "peerID": "12D3KooWRV4WeyLAwakWs6UyALv3NxgyFE2v9MKNL7WGSHqzYwcj", "direction": "out", "remoteAddr": "127.0.0.1:19002", "remotePeerID": "12D3KooWFjZzAdKxQFNjZ6fg5zaVrakKWTLzbYr1KJke5wcM4row", "id": "ragep2p", "error": "dial tcp 127.0.0.1:19002: connect: connection refused"}

Why: The error indicates that the connection attempt to the specified address and port was refused, likely because the service at that address is not running or not accepting connections.

Suggested fix: Ensure that the service at 127.0.0.1:19002 is running and configured to accept connections. Verify network configurations and service availability before initiating the connection.

3. Use of closed network connection:[Run tests with flakeguard]

Source of Error:
Run tests with flakeguard	2024-11-26T10:22:13.5685981Z logger.go:146: 2024-11-26T10:20:02.727Z	WARN	SingletonPeerWrapper	ragep2p/ragep2p.go:1251	Error reading from connection	{"version": "unset@unset", "peerID": "12D3KooWRV4WeyLAwakWs6UyALv3NxgyFE2v9MKNL7WGSHqzYwcj", "remotePeerID": "12D3KooWFwnLN2zZ9nFRbkqNXL6DcRhSdGFUbNZS1Wp6f9SWfjNF", "direction": "in", "remoteAddr": "127.0.0.1:53222", "id": "ragep2p", "error": "read tcp 127.0.0.1:19001->127.0.0.1:53222: use of closed network connection"}

Why: This error occurs when an attempt is made to read from a network connection that has already been closed, indicating a premature closure or a race condition in the connection handling.

Suggested fix: Ensure proper synchronization and lifecycle management of network connections. Avoid closing connections prematurely and handle connection closures gracefully.

4. Test failure:[Run tests with flakeguard]

Source of Error:
Run tests with flakeguard	2024-11-26T10:22:13.6095556Z --- FAIL: TestAddChainInbound (79.67s)
Run tests with flakeguard	2024-11-26T10:22:13.6095768Z Summary: 7 passed, 1 skipped, 1 failed, 1 flaky
Run tests with flakeguard	2024-11-26T10:22:13.6095946Z All test results saved to test-result.json
Run tests with flakeguard	2024-11-26T10:22:13.6106419Z ##[error]Process completed with exit code 1.

Why: The test TestAddChainInbound failed, which caused the overall process to exit with a non-zero status. The specific reason for the test failure is not detailed in the provided logs.

Suggested fix: Investigate the TestAddChainInbound test case to identify the root cause of the failure. Review the test logic, dependencies, and environment setup to ensure the test can pass consistently.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@dimkouv dimkouv changed the title ccip - Add RMNRemote.isCursed method to contract reader setup ccip - rmn cursing support Nov 20, 2024
@dimkouv dimkouv marked this pull request as ready for review November 25, 2024 15:47
@dimkouv dimkouv requested review from a team as code owners November 25, 2024 15:47
makramkd
makramkd previously approved these changes Nov 25, 2024
@dimkouv dimkouv enabled auto-merge November 25, 2024 16:09
jmank88
jmank88 previously approved these changes Nov 25, 2024
@dimkouv dimkouv dismissed stale reviews from jmank88 and makramkd via 368c561 November 26, 2024 07:34
@dimkouv dimkouv requested review from makramkd and jmank88 November 26, 2024 07:34
@dimkouv dimkouv requested a review from a team as a code owner November 26, 2024 07:48
@dimkouv dimkouv added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@dimkouv dimkouv added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@dimkouv dimkouv added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit b79da55 Nov 26, 2024
165 of 167 checks passed
@dimkouv dimkouv deleted the dk/rmn-cursing branch November 26, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants