Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/cover transmit errors #15236

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Chore/cover transmit errors #15236

merged 2 commits into from
Nov 14, 2024

Conversation

Oozyx
Copy link

@Oozyx Oozyx commented Nov 13, 2024

Requires

Supports

@Oozyx Oozyx requested a review from a team as a code owner November 13, 2024 23:53
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to contracts. Please run pnpm changeset in the contracts directory to add a changeset.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

AER Report: Operator UI CI

aer_workflow , commit , Breaking Changes GQL Check

1. Workflow conclusion is failure: [Breaking Changes GQL Check]

Source of Error: 
Run convictional/trigger-workflow-and-wait@f69fa9eedd3c62a599220f4d5745230e237904be	2024-11-14T20:16:51.8117495Z Checking conclusion [failure]
Run convictional/trigger-workflow-and-wait@f69fa9eedd3c62a599220f4d5745230e237904be	2024-11-14T20:16:51.8119319Z Checking status [completed]
Run convictional/trigger-workflow-and-wait@f69fa9eedd3c62a599220f4d5745230e237904be	2024-11-14T20:16:51.8120515Z Conclusion is not success, it's [failure].
Run convictional/trigger-workflow-and-wait@f69fa9eedd3c62a599220f4d5745230e237904be	2024-11-14T20:16:51.8124035Z Propagating failure to upstream job

Why: The triggered workflow did not complete successfully. The conclusion status was failure, which caused the upstream job to fail as well.

Suggested fix: Investigate the logs of the downstream workflow (ID: 11844815760) to identify the specific cause of the failure and address any issues found there.

AER Report: CI Core ran successfully ✅

aer_workflow , commit

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Static analysis results are available

Hey @Oozyx, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

eduard-cl
eduard-cl reviewed Nov 14, 2024
View reviewed changes
contracts/src/v0.8/feeds/DualAggregator.sol
@@ -386,9 +386,8 @@ contract DualAggregator is OCR2Abstract, Ownable2StepMsgSender, AggregatorV2V3In
/// @return the aggregatorRoundId of the next round. Note: The report for this round may have been
/// transmitted (but not yet mined) *before* requestNewRound() was even called. There is *no*
/// guarantee of causality between the request and the report at aggregatorRoundId.
// TODO: i think we can remove this function entirely
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we remove the requestNewRound() function?
I thought it would never be used.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should ask, I left it just in case we want to keep it.

@Oozyx Oozyx force-pushed the chore/cover-transmit-errors branch from f87c27e to cea5650 Compare November 14, 2024 19:29
@Oozyx Oozyx merged commit cce4aa4 into feeds-project-develop Nov 14, 2024
99 of 101 checks passed
@Oozyx Oozyx deleted the chore/cover-transmit-errors branch November 14, 2024 20:26
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard-cl eduard-cl eduard-cl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oozyx @eduard-cl