Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dual contract transmitter #15202

Merged
merged 13 commits into from
Nov 15, 2024
Merged

Add dual contract transmitter #15202

merged 13 commits into from
Nov 15, 2024

Conversation

george-dorin
Copy link
Contributor

@george-dorin george-dorin commented Nov 12, 2024

-Add dual transmitter relay config
-Add dual contract transmitter
-Remove adaptive send

-Add dual transmitter relay config
-Add dual transmitter as contract transmitter
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Nov 12, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@george-dorin george-dorin marked this pull request as ready for review November 13, 2024 13:29
@george-dorin george-dorin requested review from a team as code owners November 13, 2024 13:29
@george-dorin george-dorin requested a review from dimriou November 13, 2024 13:55
Copy link
Contributor

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and bd51049 (dual-broadcast-transmitter).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 217 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                 TestName                            PassRatio  RunCount   Skipped
---------                                                   ---------                           ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/job  TestRunner_Error_Callback_AsyncJob  0%         1          false

Send secondary tx even if primary fails
Copy link
Contributor

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and 0efa3be (dual-broadcast-transmitter).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 217 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                 TestName                            PassRatio  RunCount   Skipped
---------                                                   ---------                           ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/job  TestRunner_Error_Callback_AsyncJob  0%         1          false

Copy link
Contributor

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and b039e3a (dual-broadcast-transmitter).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 218 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                 TestName                              PassRatio  RunCount   Skipped
---------                                                   ---------                             ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/job  TestRunner_Success_Callback_AsyncJob  50%        2          false

Change DualTransmissionConfig to pointer
Copy link
Contributor

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and e8c9963 (dual-broadcast-transmitter).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 218 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                 TestName                              PassRatio           RunCount   Skipped
---------                                                   ---------                             ---------           ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/job  TestRunner_Success_Callback_AsyncJob  66.66666666666666%  3          false

Copy link
Contributor

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and 4985cf9 (dual-broadcast-transmitter).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 66 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                       TestName              PassRatio  RunCount   Skipped
---------                                                         ---------             ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/ocrcommon  Test_DualTransmitter  0%         1          false

@george-dorin george-dorin added this pull request to the merge queue Nov 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2024
@george-dorin george-dorin added this pull request to the merge queue Nov 15, 2024
Merged via the queue into develop with commit a4d3c22 Nov 15, 2024
139 of 142 checks passed
@george-dorin george-dorin deleted the dual-broadcast-transmitter branch November 15, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants