Bump chainlink-ccip and common and update Contract Reader CCIP cfgs #15137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilija42
requested review from
cedric-cordenier,
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xnogo
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
ilija42
force-pushed
the
add-ccip-reader-codec-wrapper-modifier
branch
4 times, most recently
from
845aee0 to
6090ca8
Compare
core/capabilities/ccip/ccip_integration_tests/ccipreader/ccipreader_test.go
Show resolved
Hide resolved
patrick-dowell
previously approved these changes
Nov 9, 2024
mateusz-sekara
previously approved these changes
Nov 12, 2024
ilija42
dismissed stale reviews from mateusz-sekara and patrick-dowell
via
86284b9
ilija42
force-pushed
the
add-ccip-reader-codec-wrapper-modifier
branch
2 times, most recently
from
86284b9 to
5e162a1
Compare
patrick-dowell
previously approved these changes
Nov 12, 2024
core/capabilities/ccip/ccip_integration_tests/ccipreader/ccipreader_test.go
Show resolved
Hide resolved
Farber98
previously approved these changes
Nov 12, 2024
ilija42
dismissed stale reviews from Farber98 and patrick-dowell
via
c8d1fcc
ilija42
force-pushed
the
add-ccip-reader-codec-wrapper-modifier
branch
from
5e162a1 to
c8d1fcc
Compare
EasterTheBunny
approved these changes
Nov 12, 2024
jmank88
approved these changes
Nov 12, 2024
patrick-dowell
approved these changes
Nov 12, 2024
winder
approved these changes
Nov 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Nov 12, 2024
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ccip offchain structure or i.e. the chain agnostic structure that we want to parse the results into used in MsgsBetweenSeqNums has big int values wrapped inside of this struct:
type BigInt struct { *big.Int }These added codec modifiers wrap the onchain results big int fields so that they match this offchain structure.