Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beholder logging for custom compute #15122

Merged
merged 15 commits into from
Nov 11, 2024

Conversation

vyzaldysanchez
Copy link
Contributor

Requires

Supports

@vyzaldysanchez
Copy link
Contributor Author

This is bumping common to a version not yet merged, will fix the bump as soon as the common change gets in.

@vyzaldysanchez vyzaldysanchez marked this pull request as ready for review November 5, 2024 16:11
@vyzaldysanchez vyzaldysanchez requested review from a team as code owners November 5, 2024 16:11
core/capabilities/compute/monitoring.go Outdated Show resolved Hide resolved
bolekk
bolekk previously approved these changes Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@vyzaldysanchez vyzaldysanchez force-pushed the task/CAPPL-67/custom-compute-beholder branch from 1101b83 to 935b71c Compare November 5, 2024 16:57
@vyzaldysanchez vyzaldysanchez requested a review from a team as a code owner November 5, 2024 16:57
bolekk
bolekk previously approved these changes Nov 5, 2024
core/platform/monitoring.go Outdated Show resolved Hide resolved
core/platform/monitoring.go Outdated Show resolved Hide resolved
jmank88
jmank88 previously approved these changes Nov 7, 2024
jmank88
jmank88 previously approved these changes Nov 7, 2024
patrickhuie19
patrickhuie19 previously approved these changes Nov 7, 2024
Copy link
Contributor

@patrickhuie19 patrickhuie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyzaldysanchez vyzaldysanchez added this pull request to the merge queue Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
@vyzaldysanchez vyzaldysanchez added this pull request to the merge queue Nov 7, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 7, 2024
* Adds beholder logging

* Bumps `common`

* Bumps `common`

* Bumps `common`

* Improves var naming

* make `gomodtidy`

* Repurposes monitoring keys

* Fixes CI

* Bumps CCIP

* Bumps common

* Address review comments

* Reverts unsupported approach
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
@vyzaldysanchez vyzaldysanchez added this pull request to the merge queue Nov 11, 2024
Merged via the queue into develop with commit a455950 Nov 11, 2024
138 of 139 checks passed
@vyzaldysanchez vyzaldysanchez deleted the task/CAPPL-67/custom-compute-beholder branch November 11, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants