-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add beholder logging for custom compute #15122
Merged
vyzaldysanchez
merged 15 commits into
develop
from
task/CAPPL-67/custom-compute-beholder
Nov 11, 2024
Merged
Add beholder logging for custom compute #15122
vyzaldysanchez
merged 15 commits into
develop
from
task/CAPPL-67/custom-compute-beholder
Nov 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is bumping common to a version not yet merged, will fix the bump as soon as the common change gets in. |
vyzaldysanchez
requested review from
bolekk,
patrickhuie19 and
cedric-cordenier
November 5, 2024 15:43
bolekk
requested changes
Nov 5, 2024
bolekk
previously approved these changes
Nov 5, 2024
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
vyzaldysanchez
force-pushed
the
task/CAPPL-67/custom-compute-beholder
branch
from
November 5, 2024 16:57
1101b83
to
935b71c
Compare
bolekk
previously approved these changes
Nov 5, 2024
jmank88
reviewed
Nov 7, 2024
jmank88
reviewed
Nov 7, 2024
jmank88
previously approved these changes
Nov 7, 2024
jmank88
previously approved these changes
Nov 7, 2024
patrickhuie19
previously approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving so we don't block on https://github.com/smartcontractkit/chainlink/pull/15122/files#r1832943470
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 7, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
* Adds beholder logging * Bumps `common` * Bumps `common` * Bumps `common` * Improves var naming * make `gomodtidy` * Repurposes monitoring keys * Fixes CI * Bumps CCIP * Bumps common * Address review comments * Reverts unsupported approach
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 7, 2024
vyzaldysanchez
dismissed stale reviews from patrickhuie19 and jmank88
via
November 11, 2024 16:07
fd1c66f
jmank88
approved these changes
Nov 11, 2024
patrickhuie19
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports