Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAPPL-121] propagate context on fetch #14956

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

agparadiso
Copy link
Contributor

@agparadiso agparadiso commented Oct 25, 2024

Description

This pr is the continuation of this one, basically importing this version of chainlink-commons which enables us to propagate the context and remove the context.Background() on createFetcher

CAPPL-121

Requires

Resolves

@agparadiso agparadiso marked this pull request as ready for review October 25, 2024 14:04
@agparadiso agparadiso requested review from a team as code owners October 25, 2024 14:04
Copy link
Contributor

github-actions bot commented Oct 25, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

jmank88
jmank88 previously approved these changes Oct 25, 2024
@agparadiso agparadiso force-pushed the CAPPL-121-context_propagation branch 2 times, most recently from daee064 to e3e0e02 Compare October 25, 2024 14:19
@agparadiso agparadiso requested a review from a team as a code owner October 25, 2024 14:19
@agparadiso agparadiso force-pushed the CAPPL-121-context_propagation branch from 57538fa to 2d1c349 Compare October 25, 2024 15:03
@cedric-cordenier cedric-cordenier force-pushed the CAPPL-121-context_propagation branch from ac5b773 to 6491622 Compare October 25, 2024 17:09
krehermann
krehermann previously approved these changes Oct 25, 2024
patrickhuie19
patrickhuie19 previously approved these changes Oct 25, 2024
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Oct 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 25, 2024
@cedric-cordenier cedric-cordenier dismissed stale reviews from patrickhuie19, krehermann, and themself via f262f72 October 25, 2024 17:39
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Oct 25, 2024
Merged via the queue into develop with commit f7b2544 Oct 25, 2024
131 of 132 checks passed
@cedric-cordenier cedric-cordenier deleted the CAPPL-121-context_propagation branch October 25, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants