CCIP-3799 add condition for Execution plugin in _afterOCR3ConfigSet #14951
Conversation
0xsuryansh
requested review from
RensR,
matYang,
jhweintraub and
RyanRHall
as code owners
Static analysis results are availableHey @0xsuryansh, you can view Slither reports in the job summary here or download them as artifact here. |
Solidity Review Jira issueHey! We have taken the liberty to link this PR to a Jira issue for Solidity Review. This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one. Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: This PR has been linked to Solidity Review Jira issue: CCIP-3966 |
| @@ -63,7 +63,8 @@ contract OffRamp is ITypeAndVersion, MultiOCR3Base { | |||
| error ZeroAddressNotAllowed(); | |||
| error InvalidMessageDestChainSelector(uint64 messageDestChainSelector); | |||
| error SourceChainSelectorMismatch(uint64 reportSourceChainSelector, uint64 messageSourceChainSelector); | |||
| error SignatureVerificationDisabled(); | |||
| error SignatureVerificationRequired(uint8 pluginType); | |||
There was a problem hiding this comment.
let's remove the args as these can only be thrown with a single arg which we can make a part of the error name
There was a problem hiding this comment.
| @@ -882,16 +883,23 @@ contract OffRamp is ITypeAndVersion, MultiOCR3Base { | |||
| function _afterOCR3ConfigSet( | |||
| uint8 ocrPluginType | |||
| ) internal override { | |||
| bool isEnabled = s_ocrConfigs[ocrPluginType].configInfo.isSignatureVerificationEnabled; | |||
There was a problem hiding this comment.
can you rename this to sigVerificationEnabled or something similar?
There was a problem hiding this comment.
…ndition-enforcement' into CCIP-3799_execution-plugin-precondition-enforcement
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This PR fixes a missing condition for the Execution plugin in the _afterOCR3ConfigSet function. Now, the function correctly reverts if signature verification is enabled for the Execution plugin. The updated logic ensures that:
Commit Plugin: Signature verification must be enabled.
Execution Plugin: Signature verification must be disabled.