Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use StopChan.CtxWithTimeout #14907

Merged
merged 1 commit into from
Oct 30, 2024
Merged

use StopChan.CtxWithTimeout #14907

merged 1 commit into from
Oct 30, 2024

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Oct 22, 2024

@jmank88 jmank88 mentioned this pull request Oct 22, 2024
Merged
@jmank88 jmank88 force-pushed the stop-chan-ctx-timeout branch from c259e12 to 763a126 Compare October 22, 2024 23:53
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@jmank88 jmank88 force-pushed the stop-chan-ctx-timeout branch 10 times, most recently from 313ccef to ef84b77 Compare October 24, 2024 21:09
@jmank88
Copy link
Contributor Author

jmank88 commented Oct 24, 2024 •
edited
Loading

Stuck on three linter flakes for integer overflow. Bumping golangci-lint to 1.61.0 to see if there is a fix.. 🤞

Edit: Not flakes. Fixed now.

@jmank88 jmank88 force-pushed the stop-chan-ctx-timeout branch 2 times, most recently from 3dcab4f to 4c6de09 Compare October 24, 2024 22:40
@jmank88 jmank88 marked this pull request as ready for review October 24, 2024 23:16
@jmank88 jmank88 requested review from a team as code owners October 24, 2024 23:16
@jmank88 jmank88 enabled auto-merge October 24, 2024 23:19
Farber98
Farber98 previously approved these changes Oct 25, 2024
View reviewed changes
@jmank88 jmank88 force-pushed the stop-chan-ctx-timeout branch from 4c6de09 to def58d3 Compare October 25, 2024 12:54
Farber98
Farber98 previously approved these changes Oct 25, 2024
View reviewed changes
@jmank88 jmank88 force-pushed the stop-chan-ctx-timeout branch from def58d3 to 8307d2e Compare October 25, 2024 19:23
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
86.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@jmank88 jmank88 requested a review from Farber98 October 28, 2024 13:49
infiloop2
infiloop2 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@infiloop2 infiloop2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keepers changes look good

@jmank88 jmank88 added this pull request to the merge queue Oct 30, 2024
Merged via the queue into develop with commit 99c3a01 Oct 30, 2024
130 of 131 checks passed
@jmank88 jmank88 deleted the stop-chan-ctx-timeout branch October 30, 2024 13:22
@chainchad chainchad mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@george-dorin george-dorin george-dorin approved these changes

@infiloop2 infiloop2 infiloop2 approved these changes

@Farber98 Farber98 Farber98 approved these changes

@timweri timweri timweri approved these changes

@EasterTheBunny EasterTheBunny EasterTheBunny approved these changes

@cedric-cordenier cedric-cordenier Awaiting requested review from cedric-cordenier cedric-cordenier is a code owner automatically assigned from smartcontractkit/foundations

@kalverra kalverra Awaiting requested review from kalverra

@skudasov skudasov Awaiting requested review from skudasov

@bolekk bolekk Awaiting requested review from bolekk

@HenryNguyen5 HenryNguyen5 Awaiting requested review from HenryNguyen5

@momentmaker momentmaker Awaiting requested review from momentmaker

@chainchad chainchad Awaiting requested review from chainchad

@obelisk obelisk Awaiting requested review from obelisk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jmank88 @EasterTheBunny @timweri @Farber98 @infiloop2 @george-dorin