Initial move of integration-tests/deployment to an independent module. #14893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgruber
force-pushed
the
chore/cgruber_extract_deployment
branch
10 times, most recently
from
ac26433 to
0ad517a
Compare
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
cgruber
force-pushed
the
chore/cgruber_extract_deployment
branch
from
0ad517a to
36d7a81
Compare
cgruber
force-pushed
the
chore/cgruber_extract_deployment
branch
5 times, most recently
from
ddca1bf to
c7e7649
Compare
cgruber
commented
Oct 23, 2024
cgruber
commented
Oct 23, 2024
cgruber
force-pushed
the
chore/cgruber_extract_deployment
branch
7 times, most recently
from
68a2450 to
ba50c0a
Compare
cgruber
dismissed stale reviews from krehermann, bolekk, chainchad, and skudasov
via
ca2dd56
…rate module. This updates the dependencies, and makes the integration-tests depend on both chainlink and the deployments package. A few things to fix. The go.mod entry for deployments is off, because there is no version currently checked-in. It's overridden in a replace statement, but I'm not sure if there are any contexts in which that goes wrong. It just seems weird to keep an incorrect version number there. Also: * Rename the node client to nodeclient, to disambiguate. * Move the various non-product elements into 'environment'
cgruber
force-pushed
the
chore/cgruber_extract_deployment
branch
from
ca2dd56 to
566dbe5
Compare
skudasov
approved these changes
Oct 29, 2024
krehermann
approved these changes
Oct 29, 2024
winder
approved these changes
Oct 29, 2024
|
connorwstein
approved these changes
Oct 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Oct 21, 2024
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the dependencies, and makes the integration-tests depend on both chainlink and the deployments package.