[CAPPL-132] Fetch secrets in workflow engine #14880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-cordenier
force-pushed
the
CAPPL-132-secrets-fetcher
branch
3 times, most recently
from
b8230b9 to
a79a721
Compare
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
cedric-cordenier
requested review from
a team,
RensR,
matYang,
jhweintraub,
0xsuryansh,
RyanRHall,
RayXpub and
elatoskinas
as code owners
cedric-cordenier
requested review from
winder,
rstout,
asoliman92 and
makramkd
cedric-cordenier
removed request for
jhweintraub,
elatoskinas,
0xsuryansh,
RayXpub and
0xnogo
cedric-cordenier
force-pushed
the
CAPPL-132-secrets-fetcher
branch
from
324159c to
bc6c8a3
Compare
|
ettec
approved these changes
Oct 25, 2024
agparadiso
approved these changes
Oct 25, 2024
george-dorin
approved these changes
Oct 25, 2024
krehermann
reviewed
Oct 25, 2024
| services.StateMachine | ||
| } | ||
|
|
||
| func (w *WorkflowRegistry) Start(ctx context.Context) error { |
There was a problem hiding this comment.
it's a service that doesn't start?
krehermann
approved these changes
Oct 25, 2024
This was referenced Oct 21, 2024
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a stubbed out workflow registry syncer, and implement the secretsFetcher interface.
Refactor getting the config into a single method and use this consistently across call sites. We'll also not cache the values in the engine, relying on the registries to cache for us. The performance hit associated with this should be minimal in comparison with the other calls made by the engine when executing a workflow.
Create a
logCustMsghelper which logs a custom message and codifies logging an error if emitting the message fails. A failure to emit a custom message should not interrupt the execution of the engine.Requires
Resolves