Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support cosmos as LOOP Plugin #14180

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

support cosmos as LOOP Plugin #14180

wants to merge 1 commit into from

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Aug 21, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@jmank88 jmank88 force-pushed the BCI-1971-cosmos-loopp branch 2 times, most recently from 1a6ece7 to 3f16e9b Compare August 21, 2024 13:07
@jmank88 jmank88 changed the title suppose cosmos as LOOP Plugin support cosmos as LOOP Plugin Aug 21, 2024
@jmank88 jmank88 force-pushed the BCI-1971-cosmos-loopp branch 9 times, most recently from 0ebbe4c to 87a3d3e Compare August 22, 2024 13:06
@jmank88 jmank88 requested a review from cfal August 22, 2024 13:18
archseer
archseer reviewed Aug 28, 2024
View reviewed changes
core/services/chainlink/relayer_factory.go Outdated
@@ -268,12 +269,12 @@ func (c CosmosFactoryConfig) Validate() error {
return err
}

func (r *RelayerFactory) NewCosmos(config CosmosFactoryConfig) (map[types.RelayID]CosmosLoopRelayerChainer, error) {
func (r *RelayerFactory) NewCosmos(config CosmosFactoryConfig) (map[types.RelayID]loop.Relayer, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this just use NewLOOPRelayer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm what do you mean? This is a 'universal' relayer factory, not just a Cosmos relayer factory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, is that a helper? Looks like we could switch to it after we remove the in-memory version?

@jmank88 jmank88 mentioned this pull request Aug 31, 2024
Draft
2 tasks
@jmank88 jmank88 force-pushed the BCI-1971-cosmos-loopp branch from 87a3d3e to f40291a Compare September 13, 2024 21:10
@jmank88 jmank88 force-pushed the BCI-1971-cosmos-loopp branch from f40291a to d3dfd79 Compare September 13, 2024 22:16
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
70.0% Coverage on New Code
4.6% Duplication on New Code

See analysis details on SonarQube

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 13, 2024
@jmank88 jmank88 removed the Stale label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer left review comments

@cfal cfal Awaiting requested review from cfal

@samsondav samsondav Awaiting requested review from samsondav samsondav will be requested when the pull request is marked ready for review samsondav is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmank88 @archseer