Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KS-411] Extra validation for FeedIDs in Streams Codec #14038

Merged
merged 2 commits into from
Aug 6, 2024
Merged

[KS-411] Extra validation for FeedIDs in Streams Codec #14038

merged 2 commits into from
Aug 6, 2024

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented Aug 5, 2024 •
edited
Loading

Make sure the ID extracted from FullReport matches the top-level one.

@bolekk
[KS-411] Extra validation for FeedIDs in Streams Codec
b960456 
Make sure the ID extracted from FullReport matcheds the top-level one.
@bolekk bolekk requested a review from a team August 5, 2024 22:37
@bolekk bolekk requested a review from a team as a code owner August 5, 2024 22:37
@DeividasK DeividasK enabled auto-merge August 6, 2024 11:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@DeividasK DeividasK added this pull request to the merge queue Aug 6, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Merged via the queue into develop with commit e014a13 Aug 6, 2024
116 of 118 checks passed
@DeividasK DeividasK deleted the bugfix/KS-411-codec-extract-feed-id branch August 6, 2024 15:55
momentmaker added a commit that referenced this pull request Aug 6, 2024
@momentmaker
Merge branch 'develop' into re-2756/goreleaser-build-image
800b5bf 
* develop:
  Add finalizer component to TXM (#13638)
  auto: adjust cron contract imports (#13927)
  Set PriceMin to match pip-35 definition (#14014)
  update solana e2e test build deps (#13978)
  fix data race in syncer/launcher (#14050)
  [KS-411] Extra validation for FeedIDs in Streams Codec (#14038)
  [TT-1262] dump pg on failure (#14029)
  ks-409 fix the mock trigger to ensure events are sent (#14047)
  update readme's with information about CL node TOML config (#14028)
  [CCIP-Merge] OCR2 plugins  [CCIP-2942] (#14043)
  [BCF - 3339] - Codec and CR hashed topics support (#14016)
  common version update to head of develop (#14030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@DeividasK DeividasK DeividasK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bolekk @DeividasK @cedric-cordenier