Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the log recoverer #13704

Closed
wants to merge 5 commits into from
Closed

Disable the log recoverer #13704

wants to merge 5 commits into from

Conversation

ferglor
Copy link
Collaborator

@ferglor ferglor commented Jun 26, 2024

https://smartcontract-it.atlassian.net/browse/AUTO-10074

  • Bump to a version of automation with reduced workload/cadence for recoverer
  • Reduce cached logs in core

Performance comparison

CL node stats

Enabled

image

Disabled

image

Results

When enabled, CPU usage peaks at over 2.5 and is quite erratic, mem usage approaching 2.5GB
When disabled, CPU peaks at just over 1.0 with occasional spikes, memory spike to 2GB but mostly stays at 1.25GB

DB node stats

Enabled

image

Disabled

image

Results

When enabled, CPU peaks at around 1.0, with early RAM spikes to 1 GB, but doesn't go much higher than 1GB overall
When disabled, CPU peaks just over 0.3, with no RAM spikes, but overall higher usage of 1.25

Missed logs

Enabled

image

Disabled

image

Results

No stats are reported when the recoverer is disabled

@ferglor ferglor requested review from a team as code owners June 26, 2024 23:15
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@ferglor ferglor changed the title Reduce recoverer workload Disable the log recoverer Jul 1, 2024
@ferglor ferglor closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant