Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loggercheck linter to verify that \*w logging methods have even number of args. #13599

Merged
merged 12 commits into from
Jun 21, 2024
Merged

Add loggercheck linter to verify that \*w logging methods have even number of args. #13599

merged 12 commits into from
Jun 21, 2024

Conversation

pavel-raykov
Copy link
Collaborator

No description provided.

@pavel-raykov pavel-raykov marked this pull request as ready for review June 18, 2024 08:26
@pavel-raykov pavel-raykov requested review from a team as code owners June 18, 2024 08:26
@pavel-raykov pavel-raykov requested a review from jmank88 June 18, 2024 08:26
jmank88
jmank88 previously approved these changes Jun 18, 2024
View reviewed changes
jmank88
jmank88 reviewed Jun 18, 2024
View reviewed changes
.golangci.yml Show resolved Hide resolved
@pavel-raykov pavel-raykov requested a review from a team as a code owner June 18, 2024 13:34
jmank88
jmank88 previously approved these changes Jun 18, 2024
View reviewed changes
@pavel-raykov pavel-raykov force-pushed the BCF-3255-create-golangci-lint-rule-for-vetting-logger-args branch from ee7527a to 95b93de Compare June 18, 2024 14:12
@pavel-raykov pavel-raykov requested a review from jmank88 June 18, 2024 14:30
jmank88
jmank88 reviewed Jun 18, 2024
View reviewed changes
.golangci.yml Show resolved Hide resolved
jmank88
jmank88 previously approved these changes Jun 18, 2024
View reviewed changes
@pavel-raykov pavel-raykov force-pushed the BCF-3255-create-golangci-lint-rule-for-vetting-logger-args branch from 2ad57ed to ca5eac6 Compare June 19, 2024 07:31
@pavel-raykov pavel-raykov force-pushed the BCF-3255-create-golangci-lint-rule-for-vetting-logger-args branch from 934a716 to b386e63 Compare June 19, 2024 14:02
@pavel-raykov pavel-raykov requested a review from jmank88 June 19, 2024 14:50
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
25.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@george-dorin george-dorin added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024
@jmank88 jmank88 added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024
@jmank88 jmank88 added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024
@jmank88 jmank88 added this pull request to the merge queue Jun 21, 2024
Merged via the queue into develop with commit e0ce079 Jun 21, 2024
112 checks passed
@jmank88 jmank88 deleted the BCF-3255-create-golangci-lint-rule-for-vetting-logger-args branch June 21, 2024 00:25
@github-actions github-actions bot mentioned this pull request Jun 21, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@george-dorin george-dorin george-dorin approved these changes

@jmank88 jmank88 jmank88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavel-raykov @jmank88 @george-dorin