Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog entry for gas price warning changes #12340

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

amit-momin
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Mar 7, 2024

I see that you haven't updated any README files. Would it make sense to do so?

Copy link
Collaborator

@dimriou dimriou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have to be so granular about our changes. We should add something to CHANGELOG if it has at least a moderate impact on users. For example, the message about removing warnings could have been avoided.

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@dimriou dimriou added this pull request to the merge queue Mar 7, 2024
Merged via the queue into develop with commit 803424b Mar 7, 2024
97 checks passed
@dimriou dimriou deleted the add-missing-changelog branch March 7, 2024 16:39
ogtownsend pushed a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants