Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert link/native to link/usd and native/usd #12309

Merged
merged 5 commits into from
Mar 8, 2024
Merged

convert link/native to link/usd and native/usd #12309

merged 5 commits into from
Mar 8, 2024

Conversation

RyanRHall
Copy link
Contributor

No description provided.

@RyanRHall RyanRHall requested a review from a team as a code owner March 6, 2024 00:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@RyanRHall RyanRHall marked this pull request as draft March 6, 2024 00:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

Base automatically changed from AUTO-9173-new to develop March 6, 2024 00:52
@RyanRHall RyanRHall force-pushed the AUTO-9108-swap-link-native-for-link-usd-and-native-usd branch from 0e7c22c to 1050b20 Compare March 6, 2024 18:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@RyanRHall RyanRHall force-pushed the AUTO-9108-swap-link-native-for-link-usd-and-native-usd branch from 1050b20 to 7f939cc Compare March 6, 2024 20:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@RyanRHall RyanRHall force-pushed the AUTO-9108-swap-link-native-for-link-usd-and-native-usd branch from 7f939cc to cbdc13c Compare March 7, 2024 15:16
@RyanRHall RyanRHall force-pushed the AUTO-9108-swap-link-native-for-link-usd-and-native-usd branch from cbdc13c to b5ed592 Compare March 7, 2024 15:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@RyanRHall RyanRHall force-pushed the AUTO-9108-swap-link-native-for-link-usd-and-native-usd branch from b5ed592 to 0320461 Compare March 7, 2024 15:29
@RyanRHall RyanRHall force-pushed the AUTO-9108-swap-link-native-for-link-usd-and-native-usd branch from 0320461 to b95b8ca Compare March 7, 2024 15:30
@RyanRHall RyanRHall marked this pull request as ready for review March 7, 2024 15:31
@RyanRHall RyanRHall requested a review from a team as a code owner March 7, 2024 15:31
@RyanRHall RyanRHall enabled auto-merge March 7, 2024 15:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@RyanRHall RyanRHall requested a review from shileiwill March 7, 2024 15:41
@RyanRHall RyanRHall force-pushed the AUTO-9108-swap-link-native-for-link-usd-and-native-usd branch from b95b8ca to ee7bf26 Compare March 7, 2024 15:41
shileiwill
shileiwill previously approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@shileiwill shileiwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me! I left a few questions just for my learning.

contracts/test/v0.8/automation/AutomationRegistry2_3.test.ts Show resolved Hide resolved
contracts/test/v0.8/automation/AutomationRegistry2_3.test.ts Outdated Show resolved Hide resolved
contracts/src/v0.8/automation/dev/v2_3/AutomationRegistry2_3.sol Show resolved Hide resolved
contracts/src/v0.8/automation/dev/v2_3/AutomationRegistryBase2_3.sol Show resolved Hide resolved
@RyanRHall RyanRHall force-pushed the AUTO-9108-swap-link-native-for-link-usd-and-native-usd branch from ee7bf26 to 45f5731 Compare March 8, 2024 16:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@RyanRHall RyanRHall force-pushed the AUTO-9108-swap-link-native-for-link-usd-and-native-usd branch from 23ea803 to da80521 Compare March 8, 2024 16:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@RyanRHall RyanRHall requested a review from shileiwill March 8, 2024 17:31
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@RyanRHall RyanRHall added this pull request to the merge queue Mar 8, 2024
Merged via the queue into develop with commit c258b2e Mar 8, 2024
106 of 108 checks passed
@RyanRHall RyanRHall deleted the AUTO-9108-swap-link-native-for-link-usd-and-native-usd branch March 8, 2024 21:15
ogtownsend pushed a commit that referenced this pull request Mar 14, 2024
@RyanRHall @ogtownsend
convert link/native to link/usd and native/usd (#12309)
3ba4e49 
* convert link/native to link/usd and native/usd

* fix tests

* add gethwrappers

* update tests to skip flakey

* fix failing registrar test
kidambisrinivas pushed a commit that referenced this pull request Mar 27, 2024
@RyanRHall @kidambisrinivas
convert link/native to link/usd and native/usd (#12309)
82a235e 
* convert link/native to link/usd and native/usd

* fix tests

* add gethwrappers

* update tests to skip flakey

* fix failing registrar test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shileiwill shileiwill shileiwill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanRHall @shileiwill