Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRIB Devspace Cleanup #12308

Merged
merged 12 commits into from
Mar 8, 2024
Merged

CRIB Devspace Cleanup #12308

merged 12 commits into from
Mar 8, 2024

Conversation

HenryNguyen5
Copy link
Collaborator

  • Create simplified goreleaser file for devspace
  • Reorder versioning to avoid db semver failures
  • Cleanup devspace file via using devspace native functionality

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

I see that you haven't updated any README files. Would it make sense to do so?

@chainchad chainchad mentioned this pull request Mar 6, 2024
Merged
scheibinger
scheibinger previously approved these changes Mar 6, 2024
View reviewed changes
@HenryNguyen5 HenryNguyen5 force-pushed the chore/crib_devspace_cleanup branch from 3c4ee49 to 5c7f6ad Compare March 6, 2024 15:39
chainchad
chainchad previously approved these changes Mar 6, 2024
View reviewed changes
@HenryNguyen5 HenryNguyen5 force-pushed the chore/crib_devspace_cleanup branch from c7a43f9 to 43ee121 Compare March 6, 2024 21:05
@HenryNguyen5 HenryNguyen5 force-pushed the chore/crib_devspace_cleanup branch from 43ee121 to e80ea9f Compare March 6, 2024 21:16
@HenryNguyen5 HenryNguyen5 force-pushed the chore/crib_devspace_cleanup branch from e80ea9f to ab46832 Compare March 6, 2024 21:48
@HenryNguyen5 HenryNguyen5 force-pushed the chore/crib_devspace_cleanup branch from 2a2d98d to ab46832 Compare March 6, 2024 21:53
scheibinger
scheibinger previously approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@scheibinger scheibinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, so many improvements in one PR 🚀 .

skudasov
skudasov approved these changes Mar 7, 2024
View reviewed changes
charts/chainlink-cluster/devspace.yaml Show resolved Hide resolved
charts/chainlink-cluster/devspace.yaml Show resolved Hide resolved
@skudasov skudasov self-requested a review March 7, 2024 11:56
chainchad
chainchad previously approved these changes Mar 7, 2024
View reviewed changes
@HenryNguyen5
Copy link
Collaborator Author

LGTM, but please check if we can use devspace deploy --skip-build ${tag} It doesn't work now, should we do it differently?

Addressed in 6bec550 (#12308)

@HenryNguyen5 HenryNguyen5 requested a review from skudasov March 7, 2024 19:00
@HenryNguyen5 HenryNguyen5 changed the title chore/crib devspace cleanup CRIB Devspace Cleanup Mar 7, 2024
@HenryNguyen5 HenryNguyen5 force-pushed the chore/crib_devspace_cleanup branch from 8cca229 to a1624a3 Compare March 7, 2024 22:22
@skudasov skudasov enabled auto-merge March 8, 2024 00:08
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@skudasov skudasov added this pull request to the merge queue Mar 8, 2024
Merged via the queue into develop with commit 1cdc71d Mar 8, 2024
98 checks passed
@skudasov skudasov deleted the chore/crib_devspace_cleanup branch March 8, 2024 00:38
ogtownsend pushed a commit that referenced this pull request Mar 14, 2024
@HenryNguyen5 @skudasov @ogtownsend
CRIB Devspace Cleanup (#12308)
3f21cba 
* Create simplified goreleaser file for devspace

* Reorder versioning to avoid db semver failures

* Cleanup devspace file via using devspace native functionality

* Remove redundant commit from version

* Use .env

* Remove redundant pipeline

* Remove dead docs

* Update docs to reflect new devspace changes

* Add support for tag overrides

* Update docs for image overrides

* Cleanup flag syntax

---------

Co-authored-by: Sergey Kudasov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skudasov skudasov skudasov approved these changes

@chainchad chainchad chainchad left review comments

@scheibinger scheibinger scheibinger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HenryNguyen5 @scheibinger @skudasov @chainchad