Fail to Boot if P2P Not Enabled for OCR #12005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
reviewed
Feb 12, 2024
jmank88
reviewed
Feb 12, 2024
OCR and OCR2 both require P2P.V2 to be enabled with valid listen addresses. In the case that one or both are enabled, return an error if P2P is not enabled.
EasterTheBunny
force-pushed
the
BCF-2964-validate-p2p-for-OCR
branch
from
b959200 to
15e5717
Compare
chudilka1
approved these changes
Feb 15, 2024
|
Should we mention this in the changelog? |
EasterTheBunny
force-pushed
the
BCF-2964-validate-p2p-for-OCR
branch
from
25094b6 to
57e8043
Compare
chudilka1
approved these changes
Feb 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCR and OCR2 both require P2P.V2 to be enabled with valid listen addresses. In the case that one or both are enabled, return an error if P2P is not enabled.