-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: goreleaser develop build for local and CI #11847
Changes from 42 commits
5032a1a
011d042
26b0489
fa9f57a
09893a6
8f66085
e29a738
87c9226
6cab8d6
3b8154d
21edc15
43d13a9
8dc6294
9e01db7
3862bc9
ccffe98
7427726
a465bd2
6b2fc08
91dc601
279124c
8455ff1
3666188
a37ae17
129d497
33b4845
39710d4
6d38b56
89af873
d881f06
918b48f
c401f38
43007fc
87c7aff
e5d286d
1547a6c
d620ce5
ba18508
03122b7
2256176
b502110
7bb991a
5045eee
8e3bb5e
eece142
cd0e2d1
bb20bb6
86adaf2
839d189
5254c3a
e9b4d86
5ef1f31
ebbade6
e81abeb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,6 @@ mockery 2.38.0 | |
nodejs 16.16.0 | ||
postgres 13.3 | ||
helm 3.10.3 | ||
zig 0.10.1 | ||
zig 0.11.0 | ||
golangci-lint 1.55.2 | ||
protoc 25.1 |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,6 +1,6 @@ | ||||||
module github.com/smartcontractkit/chainlink/core/scripts | ||||||
|
||||||
go 1.21.3 | ||||||
go 1.21.5 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We're up to 1.21.7 now
Suggested change
|
||||||
|
||||||
// Make sure we're working with the latest chainlink libs | ||||||
replace github.com/smartcontractkit/chainlink/v2 => ../../ | ||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
module github.com/smartcontractkit/chainlink/v2 | ||
|
||
go 1.21.3 | ||
go 1.21.5 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason this is a different vers than There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good question - @jmank88 are all of them now |
||
|
||
require ( | ||
github.com/Depado/ginprom v1.8.0 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
module github.com/smartcontractkit/chainlink/integration-tests | ||
|
||
go 1.21.4 | ||
go 1.21.5 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Different than |
||
|
||
// Make sure we're working with the latest chainlink libs | ||
replace github.com/smartcontractkit/chainlink/v2 => ../ | ||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,27 @@ | ||||||
#!/bin/bash | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
# This script is used as a temp fix the ldd linking of cosm lib for binary | ||||||
# Currently there is an issue with the go linker not working with zig | ||||||
# https://github.com/ziglang/zig/issues/18922 | ||||||
|
||||||
momentmaker marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
chainlink_path="/usr/local/bin/chainlink" | ||||||
libs_path="/usr/local/bin/libs" | ||||||
|
||||||
line=$(ldd ${chainlink_path} | grep "github.com/!cosm!wasm/wasmvm") | ||||||
|
||||||
if [ -z "$line" ]; then | ||||||
echo "Error: Path containing 'github.com/!cosm!wasm/wasmvm' not found in the ldd output." | ||||||
exit 1 | ||||||
fi | ||||||
|
||||||
path=$(echo "$line" | awk '{print $1}') | ||||||
|
||||||
if [ -z "$path" ]; then | ||||||
echo "Error: Failed to extract the path from the line." | ||||||
exit 1 | ||||||
fi | ||||||
|
||||||
trimmed_path=${path%.so*}.so | ||||||
cosm_file=$(ls ${libs_path} | grep "\.so$" | head -n 1) | ||||||
|
||||||
patchelf --remove-needed "${trimmed_path}" "$chainlink_path" | ||||||
patchelf --add-needed "$cosm_file" "$chainlink_path" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🪄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this accomplishing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it wasn't outputting the json file correct in the logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a little confused about the delimiter. Maybe we can add some comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually I was thinking just removing this completely as we don't need to know the values of those artifacts plus one of them contains secrets so github actually blocks the value anyway.
what do you think?