-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement stream specs #11685
Implement stream specs #11685
Conversation
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
I see that you haven't updated any README files. Would it make sense to do so? |
b8a89d4
to
b25acde
Compare
OffchainReporting: 1, | ||
Stream: 1, | ||
VRF: 1, | ||
Webhook: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are simply sorted to make future additions easier.
initialize := s.spec.Pipeline == nil | ||
s.RUnlock() | ||
if initialize { | ||
pipeline, err := s.spec.ParsePipeline() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the benefits of using these stream specs is that we can avoid re-parsing the dot dag on every run and instead keep the parsed pipeline
in memory.
This will probably result in some speedups especially if we are executing thousands of pipelines per second.
Is any new job type automatically supported by CLO? |
7b95603
to
d21f8ae
Compare
9a47018
to
7227a9b
Compare
k, err := app.KeyStore.P2P().GetAll() | ||
require.NoError(t, err) | ||
require.Len(t, k, 1) | ||
var pks []vrfkey.KeyV2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to change this to keep the linter happy
7227a9b
to
88791c6
Compare
Running new job types is supported automatically however each new job type will need some changes for the core node and CLO to register that they will accept jobs of that type. This is so we know how to assign the correct node for the a given job type. |
88791c6
to
40173fb
Compare
SonarQube Quality Gate |
No description provided.