-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multichain ocr3 contract transmitter #11672
Conversation
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
return nil, fmt.Errorf("abi missing Transmitted event") | ||
} | ||
|
||
err := lp.RegisterFilter(logpoller.Filter{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will never be Unregistered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do unregisters need to happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts commit 42d4b21.
LatestConfigDetails only needs to return the changedInBlock and the config digest, not the entire config contents.
SonarQube Quality Gate Reliability Rating on New Code (is worse than A) See analysis details on SonarQube Fix issues before they fail your Quality Gate with SonarLint in your IDE. |
Moving to CCIP: smartcontractkit/ccip#414 |
The Lock/Unlock plugin will need an OCR3 transmitter that can transmit to many chains based upon the info being provided in the
ReportWithInfo
struct.In order to achieve this, we need to implement two things:
ocrtypes.Account
object.FromAccount()
returns one big Account value formatted the same way as the one returned by the ContractConfigTracker in the previous bullet.With this in mind, this PR:
CombinerFn
CombinerFn
is implemented which groups all transmitters for a single signer into a singletypes.Account
object. SeeTransmitterCombiner
in the PR changes.FromAccount
matching theTransmitterCombiner
CombinerFn
implementation.shared
subdirectory of the contracts directory and adds aNoOpOCR3.sol
implementation that does nothing in_report
just to test the end-to-end of the transmitter.