VRF-798: fix "nonce too low" in load test setup when creating a subsc… #11560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
kidambisrinivas
previously approved these changes
Dec 13, 2023
dkneisly
reviewed
Dec 13, 2023
| @@ -115,6 +115,14 @@ func TestVRFV2Performance(t *testing.T) { | |||
| require.NoError(t, err) | |||
| consumers, err = vrfv2_actions.DeployVRFV2Consumers(env.ContractDeployer, coordinator, 1) | |||
| require.NoError(t, err) | |||
| err = env.EVMClient.WaitForEvents() | |||
| if err != nil { | |||
There was a problem hiding this comment.
Do we need this if statement when using require.NoError() below?
There was a problem hiding this comment.
ahh, copy/paste issue. thanks for the catch
dkneisly
approved these changes
Dec 13, 2023
|
SonarQube Quality Gate
|
jinhoonbang
approved these changes
Dec 13, 2023
kidambisrinivas
approved these changes
Dec 13, 2023
fbac
pushed a commit
that referenced
this pull request
Dec 14, 2023
#11560) * VRF-798: fix "nonce too low" in load test setup when creating a subscription * VRF-798: fix runtime issue * VRF-798: PR comments
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ription