test vrf listener processes old requests on start up

[jinhoonbang]

• test vrf listener processes old requests on start up

[github-actions]

I see that you haven't updated any README files. Would it make sense to do so?

[github-actions]

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

[ibrajer]

LGTM, the test is relatively simple but covers the exact use case.

Perhaps adding another one in the future like this:

• send multiple requests before the node shuts down
• shut down the node
• send another batch of requests while the node is down
• restart the node
• send another batch of new requests
• validate that all three batches were successfully processed and all requests are fulfilled

Not sure if this test (or a variation of it) would be beneficial or not, but the idea here is to hunt down any potential issues with queueing requests and the node processing that queue.

[jinhoonbang]

LGTM, the test is relatively simple but covers the exact use case.

Perhaps adding another one in the future like this:

• send multiple requests before the node shuts down
• shut down the node
• send another batch of requests while the node is down
• restart the node
• send another batch of new requests
• validate that all three batches were successfully processed and all requests are fulfilled

Not sure if this test (or a variation of it) would be beneficial or not, but the idea here is to hunt down any potential issues with queueing requests and the node processing that queue.

Thanks for reviewing this! Agreed on the suggested test use case. We discussed a similar test during one of the stand ups and decided to add it in QA integration test. it's not easy to add such tests in the integration tests here because the Application instance cannot be re-started once stopped.

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube