[DO NOT MERGE] AUTO load testing check #11498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
EasterTheBunny
requested changes
Dec 5, 2023
| if bucket < tokens { | ||
| return false | ||
| } | ||
| t.buckets[key] = bucket - tokens |
There was a problem hiding this comment.
This could lead to an overflow where t.buckets[key] would be the max value for uint32.
There was a problem hiding this comment.
NVM. bucket < tokens should handle this case.
bucket = 0 && tokens = 1 == true and returns false
bucket = 20 && tokens = 30 == true and returns false
bucket = 10 && tokens = 10 == false and continues safely
|
SonarQube Quality Gate
|
amirylm
force-pushed
the
auto-load-testing-check
branch
2 times, most recently
from
34681d5 to
4f86f01
Compare
amirylm
force-pushed
the
auto-load-testing-check
branch
2 times, most recently
from
cd62f6b to
af3c516
Compare
amirylm
force-pushed
the
auto-load-testing-check
branch
from
af3c516 to
3f6adc7
Compare
amirylm
force-pushed
the
auto-load-testing-check
branch
from
3f6adc7 to
f0423a5
Compare
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.