small improvements based on comments #11491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
shileiwill
commented
Dec 5, 2023
| @@ -159,7 +159,7 @@ func (s *streams) buildResult(ctx context.Context, i int, checkResult ocr2keeper | |||
| checkResults[i].IneligibilityReason = uint8(mercury.MercuryUpkeepFailureReasonMercuryAccessNotAllowed) | |||
| return | |||
| } | |||
| } else if streamsLookupResponse.IsMercuryVersionUnkown() { | |||
| } else if !streamsLookupResponse.IsMercuryV03() { | |||
shileiwill
force-pushed
the
AUTO-8099-mercury-improvements
branch
from
74812b3 to
ef0f049
Compare
shileiwill
force-pushed
the
AUTO-8099-mercury-improvements
branch
from
ef0f049 to
9ca0297
Compare
shileiwill
force-pushed
the
AUTO-8099-mercury-improvements
branch
from
9ca0297 to
2531e3c
Compare
|
SonarQube Quality Gate
|
infiloop2
approved these changes
Dec 8, 2023
momentmaker
added a commit
that referenced
this pull request
Dec 13, 2023
* develop: (56 commits) [TT-367] [TT-745] Quick and Dirty OCRv2 Soak Test (#11487) [FUN-990] s4 observability improvements (#11512) fix health monitoring (#11558) Removes Optimism Goerli from Scheduled Tests (#11559) bump Foundry to the December release (#11540) Standardize LP filter logging (#11515) Change keepers to use the default contract transmitter (#11308) bump toml/v2 and prometheus to latest patch (#11541) Remove big from core utils (#11511) Handle edge case involving blocks not being found in the db (#11298) [DEPLOY-178]: Adds Scroll L2EP Contracts (#11405) disable kaniko fallback, increase deploy wait timeout (#11548) Use multiple EL clients with ocrv2 median smoke test (#11399) Remove core utils dependencies from common (#11425) [BCF-2760] Flakey test detection improvements (#11470) go.mods: rm libp2p; rm btcd replace (#11502) wrap devspace commands (#11530) small improvements based on comments (#11491) (test): Remove unnecessary fuzzing from Functions OnTokenTransfer tests (#11517) core/scripts/common: rm ava-labs/coreth; lint (#11451) ...
fbac
pushed a commit
that referenced
this pull request
Dec 14, 2023
* small improvements based on comments * add unit test
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUTO-8099
Address comments from #11137
Test Plan:
Unit test: added a new one
Smoke test