mercury cache fixes #11448
Merged
mercury cache fixes #11448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
samsondav
commented
Dec 1, 2023
samsondav
commented
- Properly pass through config
- Key cache by feed ID, NOT by req
req is a pointer meaning subsequent calls to LatestReport will never hit the cache
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
previously approved these changes
Dec 1, 2023
samsondav
force-pushed
the
mercury_cache_fixes
branch
from
c405de4 to
edff0d7
Compare
jmank88
previously approved these changes
Dec 1, 2023
samsondav
force-pushed
the
mercury_cache_fixes
branch
2 times, most recently
from
201de34 to
f67fed3
Compare
samsondav
force-pushed
the
mercury_cache_fixes
branch
from
f67fed3 to
77bf317
Compare
jmank88
approved these changes
Dec 1, 2023
|
SonarQube Quality Gate
|
fbac
pushed a commit
that referenced
this pull request
Dec 14, 2023
* Properly pass through config * Key cache by feed ID, NOT by req req is a pointer meaning subsequent calls to LatestReport will never hit the cache * Remove logger from config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.