Fix logpoller integration tests #11440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
reductionista
force-pushed
the
domino_replay_test
branch
from
f31a38b to
937a1e4
Compare
Whenever hasFilters was false, the Eventually function was returning before ever asserting that it was true... then continuing on as if everything had succeeded since there were no assertions that failed.
The only reason this was helping the test pass was because it typically took longer for the end block to get finalized than it did for the filters to get registered... as long as we wait for the filters to be registered there's no need to wait for the end block.
reductionista
force-pushed
the
domino_replay_test
branch
from
937a1e4 to
76c744f
Compare
Tofel
reviewed
Dec 13, 2023
| @@ -191,6 +191,7 @@ func ExecuteLogPollerReplay(t *testing.T, cfg *Config, consistencyTimeout string | |||
| } | |||
|
|
|||
| l.Info().Msg("Starting replay log poller test") | |||
| l.Info().Msg("( hasFilters bug fixed )") | |||
There was a problem hiding this comment.
Could have sworn I'd removed that... gone now
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the LogPoller integration tests which prevented them from waiting until the filters were registered.
This was causing the Replay test to fail. Even though it was always completing the replay before the filters were registered (getting back 0 logs), the backup poller was making it appear as if it had received some logs. It's possible the same may have been happening with the rest of the tests, masking potential issues with the main LogPoller.
Backup poller is disabled on this branch for testing purposes. DO NOT MERGE to develop until that commit is reverted--we'll need to find a better way of disabling it for testing purposes.