Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RE-2081 All core metrics dashboard for CRIB #11396

Merged
merged 11 commits into from
Nov 30, 2023
Merged

RE-2081 All core metrics dashboard for CRIB #11396

merged 11 commits into from
Nov 30, 2023

Conversation

skudasov
Copy link
Collaborator

@skudasov skudasov commented Nov 28, 2023 •
edited
Loading

  • All core metrics listed and grouped
  • All common metrics are plotted on the dashboard
  • OCR load/volume tests added to verify the dashboard/devspace deployment

Product-specific metrics will be done as a separate sub-dashboard in the next PRs.

@skudasov skudasov requested a review from a team as a code owner November 28, 2023 09:57
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@skudasov skudasov requested a review from Tofel November 28, 2023 09:58
@skudasov skudasov changed the title All core metrics dashboard for CRIB RE-2081 All core metrics dashboard for CRIB Nov 28, 2023
@skudasov skudasov requested a review from a team as a code owner November 29, 2023 22:57
@skudasov skudasov requested review from tateexon and Tofel November 29, 2023 23:31
@skudasov skudasov force-pushed the full_metrics_dashboard branch from a5eaa59 to fa40a0e Compare November 29, 2023 23:44
@skudasov skudasov added this pull request to the merge queue Nov 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 30, 2023
@skudasov skudasov added this pull request to the merge queue Nov 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 30, 2023
@jmank88 jmank88 added this pull request to the merge queue Nov 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 30, 2023
@jmank88 jmank88 added this pull request to the merge queue Nov 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 30, 2023
@skudasov skudasov added this pull request to the merge queue Nov 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 30, 2023
@skudasov skudasov added this pull request to the merge queue Nov 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 30, 2023
@skudasov skudasov added this pull request to the merge queue Nov 30, 2023
@skudasov skudasov removed this pull request from the merge queue due to a manual request Nov 30, 2023
@skudasov skudasov enabled auto-merge November 30, 2023 11:27
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 75%)
Failed condition 4.0% 3.97% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@skudasov skudasov disabled auto-merge November 30, 2023 12:33
@skudasov skudasov enabled auto-merge November 30, 2023 12:33
@skudasov skudasov added this pull request to the merge queue Nov 30, 2023
Merged via the queue into develop with commit 44659b1 Nov 30, 2023
85 of 86 checks passed
@skudasov skudasov deleted the full_metrics_dashboard branch November 30, 2023 13:09
fbac pushed a commit that referenced this pull request Dec 14, 2023
@skudasov
RE-2081 All core metrics dashboard for CRIB (#11396)
f2f2e35 
* complete core metrics

* all core metrics

* go mod tidy

* revert go mod

* extend wasp dashboard for load tests

* run OCRv1 on devspace (#11417)

* run OCRv1 on devspace

* fix go.mod

* fix goimports

* remove external charts

* dynamic nodes connection in config

* try the same replaces from integration-tests

* fix go.sum
@snehaagni snehaagni mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tateexon tateexon tateexon approved these changes

@Tofel Tofel Awaiting requested review from Tofel

@jmank88 jmank88 Awaiting requested review from jmank88

@krehermann krehermann Awaiting requested review from krehermann

@chainchad chainchad Awaiting requested review from chainchad

@javuto javuto Awaiting requested review from javuto

@jkongie jkongie Awaiting requested review from jkongie

@samsondav samsondav Awaiting requested review from samsondav

@RensR RensR Awaiting requested review from RensR

@se3000 se3000 Awaiting requested review from se3000

@connorwstein connorwstein Awaiting requested review from connorwstein

@sdrug sdrug Awaiting requested review from sdrug

@martin-cll martin-cll Awaiting requested review from martin-cll

@reductionista reductionista Awaiting requested review from reductionista

@prashantkumar1982 prashantkumar1982 Awaiting requested review from prashantkumar1982

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skudasov @tateexon @Tofel