core/internal/cltest: simplify

[jmank88]

This PR simplifies package cltest by moving helpers which have localized use from single packages. This has two benefits:

1. reduce dependencies of cltest: this package has become a catch-all which imports everything, and requires building the whole module just to use a trivial helper func.
2. reduce dependence on cltest: some files/packages no longer depend on cltest at all.

I picked out low-hanging fruit, but there is probably much more to do here. In general, more specialized test packages for separate domains would untangle things a lot.

[github-actions]

I see that you haven't updated any README files. Would it make sense to do so?

[github-actions]

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

[jmank88]

I moved many helpers to this package, and this file in particular, since they were only used from here. However, I think something like a package evmtest (core/chains/evm/internal/evmtest) could make sense instead 🤷
@dimriou WDYT?

[dimriou]

Agree, but only for methods that are used across other test files. The ones that are only used by txmgr_test.go and "seem" of general purpose but they are not used elsewhere, I think they can stay here as you have them.

[cl-sonarqube-production]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[dimriou]

I'm ok if we merge this and do the evmtest package in a different PR. We still have to do some work on the EVM extraction side so I think that has higher priority since it will move around more things. Then we clean up what's left.