Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logs dir for Solana tests #11378

Merged

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Nov 24, 2023

No description provided.

Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

ilija42

This comment was marked as duplicate.

Copy link
Contributor

@ilija42 ilija42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test still looks at the same path?

This is the msg from CI Summary
No files were found with the provided path: /home/runner/work/chainlink/chainlink/integration-tests/logs. No artifacts will be uploaded.

@Tofel
Copy link
Contributor Author

Tofel commented Nov 24, 2023

@ ilija42 before it was looking for: /home/runner/work/chainlink-solana/chainlink-solana/integration-tests/logs, which also wasn't valid, there must be something more wrong with the path (that is if tests fail and artefact still isn't found)

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ilija42 ilija42 marked this pull request as ready for review November 24, 2023 18:23
@ilija42 ilija42 requested a review from a team as a code owner November 24, 2023 18:23
@ilija42 ilija42 merged commit 9f831e6 into BCF-2612-ChainReader-EVM-POC Nov 24, 2023
83 of 85 checks passed
@ilija42 ilija42 deleted the BCF-2612-ChainReader-EVM-POC-fix-logs-dir branch November 24, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants