Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BCF-2738] Push images to chainlink-develop ECR #11279

Merged
merged 1 commit into from
Nov 16, 2023
Merged

[BCF-2738] Push images to chainlink-develop ECR #11279

merged 1 commit into from
Nov 16, 2023

Conversation

cedric-cordenier
Copy link
Contributor

@cedric-cordenier cedric-cordenier commented Nov 14, 2023 •
edited
Loading

I'm using hardcoded values for now for a couple of reasons:

  • to test the workflow out
  • while waiting for security to add the values as secrets to the GH environment (note: they aren't really secrets in the traditional sense)

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@cedric-cordenier
[BCF-2738] Modify build-publish-develop ECR
6017ee9 
- push images to chainlink-develop in production rather than
chainlink in the sdlc environment.
@cedric-cordenier cedric-cordenier changed the title test changes to workflow [BCF-2738] Push images to chainlink-develop ECR Nov 16, 2023
@cedric-cordenier cedric-cordenier marked this pull request as ready for review November 16, 2023 10:17
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Nov 16, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Merged via the queue into develop with commit bd5a35b Nov 16, 2023
89 checks passed
@cedric-cordenier cedric-cordenier deleted the BCF-2783 branch November 16, 2023 10:52
cedric-cordenier added a commit that referenced this pull request Nov 16, 2023
@cedric-cordenier
Revert "[BCF-2738] Modify build-publish-develop ECR (#11279)"
f91374c 
This reverts commit bd5a35b.
github-merge-queue bot pushed a commit that referenced this pull request Nov 16, 2023
@cedric-cordenier
Revert "[BCF-2738] Modify build-publish-develop ECR (#11279)" (#11310)
af2f919 
This reverts commit bd5a35b.
@snehaagni snehaagni mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@george-dorin george-dorin george-dorin approved these changes

@chainchad chainchad Awaiting requested review from chainchad

@javuto javuto Awaiting requested review from javuto

@jkongie jkongie Awaiting requested review from jkongie

@jmank88 jmank88 Awaiting requested review from jmank88

@samsondav samsondav Awaiting requested review from samsondav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cedric-cordenier @george-dorin