Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCI-2376 TXM as service. Post TX endpoint. #11256

Closed
wants to merge 21 commits into from
+643 −29
Closed

BCI-2376 TXM as service. Post TX endpoint. #11256

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f2d5f60
Create Evm Transaction Endpoint
dhaidashenko Nov 9, 2023
0213c09
rewrite tests to use mocks
dhaidashenko Nov 9, 2023
9958ec3
improve tests coverage
dhaidashenko Nov 10, 2023
1ddc0eb
Flag to enable Txm as service
dhaidashenko Nov 10, 2023
d587ff4
require admin role to send tx
dhaidashenko Nov 10, 2023
80c4fb7
moved question into PR
dhaidashenko Nov 10, 2023
c6142c3
Merge branch 'develop' into feature/BCI-2376-post-tx-endpoint
dhaidashenko Nov 10, 2023
565c9c3
fix config docs
dhaidashenko Nov 10, 2023
e2dde3b
address comments
dhaidashenko Nov 14, 2023
010a1ca
Merge branch 'develop' into feature/BCI-2376-post-tx-endpoint
dhaidashenko Nov 15, 2023
c29f27d
remove redundant dependency
dhaidashenko Nov 16, 2023
1dd2430
proper status code on tx failure
dhaidashenko Nov 16, 2023
94a3c0a
wait for tx attempt to return properly populated resource
dhaidashenko Nov 16, 2023
4c23c16
remove evm config mock generation
dhaidashenko Nov 16, 2023
c70bb5d
handle fee bump
dhaidashenko Nov 16, 2023
ac995da
Merge branch 'develop' into feature/BCI-2376-post-tx-endpoint
dhaidashenko Nov 16, 2023
0c4af4e
fixed merge
dhaidashenko Nov 16, 2023
d8bf685
switch to feature flag
dhaidashenko Nov 21, 2023
5178e0b
Merge branch 'develop' into feature/BCI-2376-post-tx-endpoint
dhaidashenko Nov 21, 2023
be19e4f
Merge branch 'develop' into feature/BCI-2376-post-tx-endpoint
dhaidashenko Nov 22, 2023
2d52d70
switch to sqlx.REbind for dynamic sql query
dhaidashenko Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/chains/evm/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"github.com/smartcontractkit/chainlink/v2/core/config"
)

//go:generate mockery --quiet --name EVM --output ./mocks/ --case=underscore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have moved away from mocking config interfaces since they were cause a lot of problems. How is this one being used?

Copy link
Collaborator Author

@dhaidashenko dhaidashenko Nov 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chainlink/core/web/evm_transactions_controller.go

Line 142 in e2dde3b

tx.FeeLimit = chain.Config().EVM().GasEstimator().LimitDefault()

This is the only way that I could get access to the default gas limit.
Is it better to introduce new method on chain.GasEstimator() that would return default gas limit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what you mean. Are we able to use a fake config type? Or a real config type populated with the values that we need? Mockery types comes with a ton of extra baggage.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example:

chainlink/core/chains/evm/txmgr/test_helpers.go

Line 43 in 1208fb3

type TestEvmConfig struct {

type EVM interface {
HeadTracker() HeadTracker
BalanceMonitor() BalanceMonitor
Expand Down
16 changes: 16 additions & 0 deletions core/chains/evm/config/mocks/chain_scoped_config.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading