plugins: remove cmd/chainlink-starknet #11058
Conversation
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
force-pushed
the
BCF-2701-rm-starknet-cmd
branch
2 times, most recently
from
327d8fc to
19c44a7
Compare
There was a problem hiding this comment.
go install would have been so much cleaner, but at least we know how to make this work already.
There was a problem hiding this comment.
@krehermann Where does this information belong?
I overlooked it at first, but now that I'm reading it, I'm not sure if it belongs in chainlink-starknet, or maybe chainlink-relay instead. WDYT?
There was a problem hiding this comment.
FWIW I vote chainlink-starknet
There was a problem hiding this comment.
+1 for chainlink-starknet since it's starknet specific
There was a problem hiding this comment.
It is starknet specific but the keystore details leak through a bit in to the relayer.
jmank88
force-pushed
the
BCF-2701-rm-starknet-cmd
branch
from
19c44a7 to
a6cc92f
Compare
There was a problem hiding this comment.
+1 for chainlink-starknet since it's starknet specific
|
Updated with final starknet/relayer hash. |
|
SonarQube Quality Gate
|
https://smartcontract-it.atlassian.net/browse/BCF-2701
Requires: