More randomising of externalJobID and name #11008
Conversation
cedric-cordenier
commented
Oct 19, 2023
cedric-cordenier
commented
- Also inline specs that are only used in one place, and remove unused specs.
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
cedric-cordenier
force-pushed
the
randomize-name-external-job-ids
branch
4 times, most recently
from
e67297b to
c4e1a98
Compare
- Also inline specs that are only used in one place, and remove unused specs.
cedric-cordenier
force-pushed
the
randomize-name-external-job-ids
branch
from
c4e1a98 to
62a4523
Compare
cedric-cordenier
requested review from
jkongie,
jmank88 and
samsondav
as code owners
| @@ -352,7 +434,6 @@ func TestIntegration_DirectRequest(t *testing.T) { | |||
| for _, tt := range tests { | |||
| test := tt | |||
| t.Run(test.name, func(t *testing.T) { | |||
| t.Parallel() | |||
There was a problem hiding this comment.
Note: I had to remove this to get the tests to pass reliably. Because each test is setting up its own simulator, making them run in parallel is causing both simulators to race when adding transactions, and seems to be causing a deadlock somewhere. I want to keep momentum up so am not going to tackle that particular issue at this time.
| """ | ||
| ` | ||
|
|
||
| const multiWordSpecTemplate = ` |
There was a problem hiding this comment.
No preference, but did you consider using package embed for these instead of moving them in here?
There was a problem hiding this comment.
I didn't, but I think this is a better way of doing this so I've amended it.
cedric-cordenier
force-pushed
the
randomize-name-external-job-ids
branch
from
b81b968 to
df5c761
Compare
cedric-cordenier
force-pushed
the
randomize-name-external-job-ids
branch
from
df5c761 to
a1f9ea2
Compare
|
SonarQube Quality Gate
|
