[TT-644] allow to define a custom cleanup function + no default cleanup #10980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nv + do not use any default cleanup
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
lukaszcl
previously approved these changes
Oct 18, 2023
Tofel
changed the title
tateexon
approved these changes
Oct 19, 2023
|
SonarQube Quality Gate
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
gheorghestrimtu
deleted the
tt_644_allow_for_custom_docker_env_cleanup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possible disadvantage: impossible to define a clean up function that would need to use variables from execution/build context (as opposed to definition context).