fix logIndex bug in debugging script #10939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
ogtownsend
reviewed
Oct 12, 2023
RyanRHall
force-pushed
the
bug-in-debug
branch
from
d9b4c0a to
ee65ce9
Compare
RyanRHall
force-pushed
the
bug-in-debug
branch
from
ee65ce9 to
bbd32e1
Compare
|
SonarQube Quality Gate
See analysis details on SonarQube Fix issues before they fail your Quality Gate with |
| @@ -269,6 +278,8 @@ func (k *Keeper) Debug(ctx context.Context, args []string) { | |||
| failUnknown("failed to pack raw checkUpkeep call", err) | |||
| } | |||
| addLink("checkCallback simulation", tenderlySimLink(k.cfg, chainID, blockNum, rawCall, registryAddress)) | |||
| } else { | |||
| message("did not revert with StreamsLookup error") | |||
There was a problem hiding this comment.
this line is so important
FelixFan1992
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.