[BCF-2689] Use an in-memory keystore for tests #10897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-cordenier
force-pushed
the
tests-stop-using-keystore
branch
from
7ce5d15 to
a1f4178
Compare
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
I see that you haven't updated any README files. Would it make sense to do so? |
cedric-cordenier
force-pushed
the
tests-stop-using-keystore
branch
9 times, most recently
from
65e330d to
3ab5268
Compare
cedric-cordenier
changed the title
cedric-cordenier
force-pushed
the
tests-stop-using-keystore
branch
2 times, most recently
from
5fccbc0 to
5fed62f
Compare
cedric-cordenier
requested review from
a team,
connorwstein,
samsondav,
RyanRHall,
archseer,
cfal,
prashantkumar1982 and
jmank88
as code owners
jmank88
reviewed
Oct 11, 2023
jmank88
reviewed
Oct 11, 2023
jmank88
reviewed
Oct 11, 2023
cedric-cordenier
force-pushed
the
tests-stop-using-keystore
branch
from
5fed62f to
b7b0d15
Compare
jmank88
previously approved these changes
Oct 11, 2023
george-dorin
previously approved these changes
Oct 11, 2023
cedric-cordenier
dismissed stale reviews from george-dorin and jmank88
via
e8c6801
cedric-cordenier
force-pushed
the
tests-stop-using-keystore
branch
5 times, most recently
from
f8a1e2c to
c50fe85
Compare
auto-merge was automatically disabled
October 12, 2023 12:54
Pull request was closed
cedric-cordenier
force-pushed
the
tests-stop-using-keystore
branch
3 times, most recently
from
6b94f6a to
ece97c3
Compare
cedric-cordenier
requested review from
chainchad,
javuto and
jkongie
as code owners
cedric-cordenier
force-pushed
the
tests-stop-using-keystore
branch
3 times, most recently
from
f2161fd to
83b9d4a
Compare
- Remove unused migration methods from the keystore - Split the keystore ORM in two, between methods which access the `encrypted_key_rings` table, and methods which access `evm.key_states` - Create an in-memory version of the base ORM, which doesn't actually write to the DB. Methods which access `evm.key_states` are unaffected by this. This will prevent tests from competing to get a row-level lock on the singleton keystore record. - Start using this in-memory keystore in `cltest` and in tests generally. Note: tests in the keystore package themselves are unaffected by this, since we still want to have test coverage over the behaviour that accesses the DB.
cedric-cordenier
force-pushed
the
tests-stop-using-keystore
branch
from
8a63448 to
ebedb38
Compare
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encrypted_key_ringstable, and methods which accessevm.key_stateswrite to the DB. Methods which access
evm.key_statesare unaffectedby this. This will prevent tests from competing to get a row-level
lock on the singleton keystore record.
cltestand in testsgenerally. Note: tests in the keystore package themselves are
unaffected by this, since we still want to have test coverage over the
behaviour that accesses the DB.