Remove legacy secrets support #10865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
bolekk
requested changes
Oct 6, 2023
| Data *computationData `json:"data"` | ||
| } | ||
|
|
||
| type computationData struct { |
There was a problem hiding this comment.
Can we add omitempty to Secrets field in RequestData instead of creating a copy of the same struct?
| @@ -13,7 +13,7 @@ import ( | |||
| var ( | |||
| // a batch of 8 max-length results uses around 2M gas (assuming 70k gas per client callback - see FunctionsClientExample.sol) | |||
| nOracleNodes = 4 | |||
| nClients = 50 | |||
| nClients = 1 | |||
| @@ -27,33 +27,6 @@ func TestIntegration_Functions_MultipleV1Requests_Success(t *testing.T) { | |||
|
|
|||
| utils.SetupRouterRoutes(t, b, owner, routerContract, active.Address, proposed.Address, allowListContractAddress) | |||
|
|
|||
| _, _, oracleIdentities := utils.CreateFunctionsNodes(t, owner, b, routerAddress, nOracleNodes, maxGas, nil, nil) | |||
There was a problem hiding this comment.
Why are you removing this? Can't we keep it with empty secrets?
core/services/ocr2/plugins/functions/integration_tests/v1/functions_integration_test.go
Show resolved
Hide resolved
bolekk
reviewed
Oct 11, 2023
core/services/ocr2/plugins/functions/integration_tests/v1/functions_integration_test.go
Show resolved
Hide resolved
| require.Equal(t, functions.LocationRemote, int(data["secretsLocation"].(float64))) | ||
| if data["secrets"] != DefaultSecretsBase64 && request["nodeProvidedSecrets"] != fmt.Sprintf(`{"0x0":"%s"}`, DefaultSecretsBase64) { | ||
| assert.Fail(t, "expected secrets or nodeProvidedSecrets to be '%s'", DefaultSecretsBase64) | ||
| if data["secrets"] != nil { |
There was a problem hiding this comment.
"secrets" will always be nil now, right? Did you mean to check "nodeProvidedSecrets" here?
bolekk
approved these changes
Oct 11, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.