Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/services: remove unused pg.QOpts from Delegate.ServicesForSpec #10844

Merged
merged 1 commit into from
Oct 3, 2023
Merged

core/services: remove unused pg.QOpts from Delegate.ServicesForSpec #10844

merged 1 commit into from
Oct 3, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Oct 3, 2023

None of the ServicesForSpec implementations use qopts ...pg.QOpt.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@jmank88 jmank88 marked this pull request as ready for review October 3, 2023 02:53
@jmank88 jmank88 enabled auto-merge October 3, 2023 02:56
@jmank88 jmank88 force-pushed the simpler-services-for-spec branch from 9f61ac5 to bec586f Compare October 3, 2023 03:03
@jmank88 jmank88 force-pushed the simpler-services-for-spec branch from bec586f to eb1354a Compare October 3, 2023 03:05
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition C Maintainability Rating on New Code (is worse than A)
Failed condition 12.0% Technical Debt Ratio on New Code (is greater than 4%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

makramkd
makramkd approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@makramkd makramkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jmank88 jmank88 added this pull request to the merge queue Oct 3, 2023
Merged via the queue into develop with commit 9a65ab2 Oct 3, 2023
@jmank88 jmank88 deleted the simpler-services-for-spec branch October 3, 2023 09:40
@snehaagni snehaagni mentioned this pull request Nov 14, 2023
Closed
asoliman92 pushed a commit that referenced this pull request Jul 31, 2024
@mateusz-sekara
Revert "core/services: remove unused pg.QOpts from Delegate.ServicesF…
536121a 
…orSpec (#10844)"

This reverts commit 9a65ab2.
asoliman92 pushed a commit that referenced this pull request Jul 31, 2024
@mateusz-sekara
Revert "core/services: remove unused pg.QOpts from Delegate.ServicesF…
7d332c9 
…orSpec (#10844)" (#317)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makramkd makramkd makramkd approved these changes

@samsondav samsondav Awaiting requested review from samsondav

@krehermann krehermann Awaiting requested review from krehermann

@connorwstein connorwstein Awaiting requested review from connorwstein

@jkongie jkongie Awaiting requested review from jkongie

@PiotrTrzpil PiotrTrzpil Awaiting requested review from PiotrTrzpil

@sdrug sdrug Awaiting requested review from sdrug

@martin-cll martin-cll Awaiting requested review from martin-cll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmank88 @makramkd