Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linea soak #10641

Merged
merged 17 commits into from
Oct 20, 2023
Merged

Linea soak #10641

merged 17 commits into from
Oct 20, 2023

Conversation

davidcauchi
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@davidcauchi davidcauchi added the build-test-image Will build the e2e test image in integration-tests workflow for PRs label Sep 14, 2023
@davidcauchi davidcauchi force-pushed the feature/BCI-1333-Linea-Soak-v2 branch from 262a6a5 to ca137b0 Compare September 14, 2023 21:43
@davidcauchi davidcauchi force-pushed the feature/BCI-1333-Linea-Soak-v2 branch 2 times, most recently from 415bdcc to 8f02d99 Compare October 5, 2023 20:41
@davidcauchi davidcauchi marked this pull request as ready for review October 5, 2023 21:09
simsonraj
simsonraj previously approved these changes Oct 11, 2023
View reviewed changes
jmank88
jmank88 previously approved these changes Oct 11, 2023
View reviewed changes
@simsonraj simsonraj added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2023
prashantkumar1982
prashantkumar1982 reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@prashantkumar1982 prashantkumar1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a question on the blockhistoryestimator size

core/chains/evm/config/toml/defaults/Linea_Mainnet.toml Outdated Show resolved Hide resolved
@davidcauchi davidcauchi marked this pull request as draft October 11, 2023 15:39
@davidcauchi davidcauchi force-pushed the feature/BCI-1333-Linea-Soak-v2 branch from 3a73891 to 5d3eb76 Compare October 12, 2023 10:50
@davidcauchi davidcauchi marked this pull request as ready for review October 19, 2023 16:43
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@simsonraj simsonraj added this pull request to the merge queue Oct 20, 2023
Merged via the queue into develop with commit bdec2c1 Oct 20, 2023
83 checks passed
@simsonraj simsonraj deleted the feature/BCI-1333-Linea-Soak-v2 branch October 20, 2023 08:08
@snehaagni snehaagni mentioned this pull request Nov 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simsonraj simsonraj simsonraj approved these changes

@jmank88 jmank88 jmank88 approved these changes

@chainchad chainchad Awaiting requested review from chainchad

@javuto javuto Awaiting requested review from javuto

@jkongie jkongie Awaiting requested review from jkongie

@samsondav samsondav Awaiting requested review from samsondav

@smickovskid smickovskid Awaiting requested review from smickovskid

@dimriou dimriou Awaiting requested review from dimriou

@prashantkumar1982 prashantkumar1982 Awaiting requested review from prashantkumar1982

Assignees
No one assigned
Labels
build-test-image Will build the e2e test image in integration-tests workflow for PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidcauchi @jmank88 @simsonraj @dimriou @prashantkumar1982